Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger autocomplete-plus when it's not typing when using enter for selecting. #255

Closed
vilicvane opened this issue Apr 13, 2015 · 3 comments

Comments

@vilicvane
Copy link
Contributor

image

Or if I press enter for new line here, it completes "value".

@basarat
Copy link
Member

basarat commented Apr 13, 2015

Thanks for reporting ❤️ Known issue. Duplicate of : #255

Workaround : don't map enter to autocomplete plus submit. The default is only that tab is mapped. You must have set it explicitly.

Note: this is how autocomplete-plus is designed, provide suggestions as aggressively as it can.

@basarat basarat closed this as completed Apr 13, 2015
@vilicvane
Copy link
Contributor Author

Hmm, this issue is #255 and it can't be a duplicate of itself, LOL...

I looked at the GIF demo from autocomplete-plus, but it seems that it's not that aggressive as it is in TypeScript files. I believe maybe it's atom-typescript triggering it too much? https://atom.io/packages/autocomplete-plus

Also my workmates are complaining about the enter key issue as most of them are used to entering for completion.

It would be great if there was an option to make auto complete for TypeScript less aggressive (align with default behavior of autocomplete-plus).

Thanks for your great work.

@basarat
Copy link
Member

basarat commented Apr 16, 2015

Sorry. Duplicate of #141 🌹

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants