This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Update input class for proper sizing #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandavidson
suggested changes
Apr 23, 2020
frontend/src/app/application-forms/fields/activity-description.component.html
Outdated
Show resolved
Hide resolved
briandavidson
suggested changes
May 22, 2020
There was a problem hiding this comment.
@Dmac26 seeing some issues on this one:
- The form section descriptions should be bold i.e "Anticipated number of trips"
- There is no validation text for the "Anticipated number of trips" field
- "Anticipated party size" field incorrectly allows text characters
|
@briandavidson @mtlaney - I reached out to Aquib to verify what to do with the labels here. I advised me to keep that text unbolded. I fixed everything else though. Please review the corrections when you can. |
briandavidson
suggested changes
Jun 11, 2020
frontend/src/app/application-forms/validators/number-validation.ts
Outdated
Show resolved
Hide resolved
mtlaney
suggested changes
Jun 16, 2020
frontend/src/app/application-forms/fields/noncommercial-fields.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/application-forms/fields/activity-description.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/application-forms/fields/activity-description.component.html
Outdated
Show resolved
Hide resolved
Dmac26
requested review from
briandavidson
and removed request for
briandavidson
briandavidson
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
There was one remaining "Resolve Conversation" button to click. I was feeling brave so I went ahead and clicked it for ya 😁
I know we had talked about it on slack too but just a reminder, going forward feel free to hit that button and request a re-review and it'll help get these moving along quicker. Nice work! 💥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses Issue #1213
This code update completes the 1213 card by updating all related .html, .ts, and .scss files to ensure that all numeric fields referenced in the 1213 card have their width reduced and validation updated to allow numeric ranges to be input with dashes included.
This pull request is ready to merge when...