Feature/update cesm driver namelist defaults #800

dgergel · 2018-05-24T19:55:08Z

closes default namelist settings for CESM driver need to be updated #799
tests passed
new tests added
science test figures
ran uncrustify prior to final commit
ReleaseNotes entry

…odes, default output variables and default output filename

jhamman · 2018-05-24T20:01:28Z

docs/Development/ReleaseNotes.md

@@ -54,55 +54,59 @@ This is a minor update from VIC 5.0.1. The VIC 5.1.0 includes new features, such
    - Fixed bug that prevented using the correct local domain grid cells in `cesm_put_data.c`
    - Changed reference temperature units from Celsius to Kelvin in `cesm_put_data.c`

-   1. [GH#695](https://github.com/UW-Hydro/VIC/pull/695)
+   2. [GH#695](https://github.com/UW-Hydro/VIC/pull/695)


markdown automatically numbers this so the 1. was intentional here.

As @jhamman says. Leave the 1 for all the numbered entries. The 1 just indicates that markdown should format this as an enumerated list and will take care of the actual numbering. It is much easier to leave that to markdown in case the list ever gets updated.

jhamman · 2018-05-24T20:01:47Z

vic/drivers/cesm/bld/build_vic_namelist

@@ -91,7 +91,8 @@ def copy_to_rundir(grid_config, caseid, rundir, casedocs):

        # copy file
        copy_clean_vic_config(grid_config[filekey], dst_file,
-                              header=header, rundir=rundir, **grid_config)
+                              header=header, rundir=rundir, 
+			      caseid=caseid, **grid_config)


indentation error here.

jhamman · 2018-05-24T20:11:06Z

vic/drivers/cesm/bld/vic.globalconfig.txt

 OUT_FORMAT  NETCDF4_CLASSIC
-OUTVAR      OUT_PREC
+HISTFREQ    END 


for both of these streams, I think you probably want the HISTFREQ frequency to be nmonths 1

What would HISTFREQ END do?

Write one file with all history timesteps in it at the final timestep. This is probably not what you want.

Updated as suggested

jhamman · 2018-05-24T20:11:08Z

vic/drivers/cesm/bld/vic.globalconfig.txt

+OUTVAR      OUT_SURF_TEMP
+OUTVAR      OUT_SWNET
+OUTVAR      OUT_LWNET
+OUTVAR      OUT_GRND_FLUX


suggest adding frozen soil variables. You and @bartnijssen should probably iterate together on which variables you think would be potentially useful.

Having something that let's us identify active layer depth would be useful, but now sure whether that would be part of every run. Same for all these met variables. Can we split out the radiation variables (down and up rather than just net).

That's what I was thinking too. From knowing how much outputting data for 10 thermal nodes increases the size of the output files, I think we should add that when we need it and not make it the default. I'll split out the radiation variables and remove some of the met ones

Remember this is just a monthly output file so the cost of writing out 3d vars is much less than it would otherwise be. My thought is that you should write out more variables, unless you have reason to think the data volumes will be out of control or that it is negatively impacting runtimes.

I added soil node temperature to the monthly output files as well as eliminating some of the met vars and splitting out the radiation vars. @bartnijssen and @jhamman - what do you think of the updated ones?

bartnijssen · 2018-05-31T18:02:55Z

docs/Development/ReleaseNotes.md

@@ -54,55 +54,59 @@ This is a minor update from VIC 5.0.1. The VIC 5.1.0 includes new features, such
    - Fixed bug that prevented using the correct local domain grid cells in `cesm_put_data.c`
    - Changed reference temperature units from Celsius to Kelvin in `cesm_put_data.c`

-   1. [GH#695](https://github.com/UW-Hydro/VIC/pull/695)
+   2. [GH#695](https://github.com/UW-Hydro/VIC/pull/695)


As @jhamman says. Leave the 1 for all the numbered entries. The 1 just indicates that markdown should format this as an enumerated list and will take care of the actual numbering. It is much easier to leave that to markdown in case the list ever gets updated.

bartnijssen · 2018-05-31T18:04:05Z

vic/drivers/cesm/bld/vic.globalconfig.txt

 OUT_FORMAT  NETCDF4_CLASSIC
-OUTVAR      OUT_PREC
+HISTFREQ    END 


What would HISTFREQ END do?

bartnijssen · 2018-05-31T18:06:33Z

vic/drivers/cesm/bld/vic.globalconfig.txt

+OUTVAR      OUT_SURF_TEMP
+OUTVAR      OUT_SWNET
+OUTVAR      OUT_LWNET
+OUTVAR      OUT_GRND_FLUX


Having something that let's us identify active layer depth would be useful, but now sure whether that would be part of every run. Same for all these met variables. Can we split out the radiation variables (down and up rather than just net).

…_cesm_driver_global_param_defaults

dgergel · 2018-08-24T22:55:11Z

@bartnijssen @jhamman just noticed this didn't get merged before - can one of you go ahead and merge it?

jhamman · 2018-08-24T23:10:26Z

vic/drivers/cesm/bld/build_vic_namelist

@@ -91,7 +91,8 @@ def copy_to_rundir(grid_config, caseid, rundir, casedocs):

        # copy file
        copy_clean_vic_config(grid_config[filekey], dst_file,
-                              header=header, rundir=rundir, **grid_config)
+                              header=header, rundir=rundir, 
+			       caseid=caseid, **grid_config)


can you fix the indentation of this line?

jhamman · 2018-08-24T23:38:12Z

vic/drivers/cesm/bld/build_vic_namelist

@@ -91,7 +91,8 @@ def copy_to_rundir(grid_config, caseid, rundir, casedocs):

        # copy file
        copy_clean_vic_config(grid_config[filekey], dst_file,
-                              header=header, rundir=rundir, **grid_config)
+                              header=header, rundir=rundir, 
+			                  caseid=caseid, **grid_config)


this still looks funny 😉

Ugh it didn't look weird on my end; I think it's fine now

i reviewed it

dgergel added 4 commits May 23, 2018 16:40

update global parameter defaults for full energy, number of thermal n…

31625ee

…odes, default output variables and default output filename

update output defaults to include monthly and daily output

b6a25c4

update to specify correct caseid

ab8b5cc

update syntax

42741c8

dgergel added the CESM driver label May 24, 2018

dgergel self-assigned this May 24, 2018

dgergel requested review from bartnijssen and jhamman May 24, 2018 19:55

add release notes entry and overall cleanup of CESM driver updates

46dc9e0

jhamman approved these changes May 24, 2018

View reviewed changes

bartnijssen previously requested changes May 31, 2018

View reviewed changes

dgergel added 5 commits May 31, 2018 16:00

Merge branch 'develop' of github.com:UW-Hydro/VIC into feature/update…

d4c1a79

…_cesm_driver_global_param_defaults

switch back for markdown automatic numbering

dd22880

fix indentation error

a5aa6bd

update histfreq and default output vars

8c3ffec

add soil node temperature to monthly outputs

29364dc

jhamman reviewed Aug 24, 2018

View reviewed changes

jhamman approved these changes Aug 24, 2018

View reviewed changes

fix indentation

9f3a4c9

jhamman reviewed Aug 24, 2018

View reviewed changes

fix indent again

76feedb

jhamman merged commit 49f6263 into UW-Hydro:develop Aug 28, 2018

dgergel mentioned this pull request Sep 9, 2018

default namelist settings for CESM driver need to be updated #799

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/update cesm driver namelist defaults #800

Feature/update cesm driver namelist defaults #800

dgergel commented May 24, 2018 •

edited

Loading

jhamman May 24, 2018

bartnijssen May 31, 2018

jhamman May 24, 2018

jhamman May 24, 2018

bartnijssen May 31, 2018

jhamman May 31, 2018

dgergel May 31, 2018

jhamman May 24, 2018

bartnijssen May 31, 2018

dgergel May 31, 2018

jhamman May 31, 2018

dgergel May 31, 2018

bartnijssen May 31, 2018

bartnijssen May 31, 2018

bartnijssen May 31, 2018

dgergel commented Aug 24, 2018

jhamman Aug 24, 2018

dgergel Aug 24, 2018

jhamman Aug 24, 2018

dgergel Aug 27, 2018

Feature/update cesm driver namelist defaults #800

Feature/update cesm driver namelist defaults #800

Conversation

dgergel commented May 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgergel commented Aug 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgergel commented May 24, 2018 •

edited

Loading