move uproxy-docker here #2841
Merged
move uproxy-docker here #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osx now uses docker-machine
output the vm ip on osx
a script to create a cloud instance
update firefox download logic for new download system
replace passwords in invite codes with private keys
* update paths to account for new uproxy output folder
* move to unbranded firefox builds
Accept public key (-k option) for install-cloud scripts
… move to alpine for smaller image (#106)
|
👍 for this change, although it seems like we might need to wait a while before we remove the uproxy-docker repo, since users currently have versions of uProxy installed which refer to install-cloud.sh in that repo right? It seems like maybe the next step will be to change https://github.com/uProxy/uproxy-cloud-install/blob/master/src/digital-ocean-installer.ts#L48 to refer to the new location |
|
Yes! It's not quite time to update all the references to uproxy-docker - but I do agree that should be next and should happen soon. Thanks for reviewing, I know this wasn't very easy to examine :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies across all of https://github.com/uProxy/uproxy-docker to a new folder named
docker.This will make it a lot easier to develop changes affecting both repos. Motivation for doing this now is to make Node.js development easier.
The files are unchanged except for the
-poption ofrun_pair.shandrun_cloud.shwhich changes from a string flag meaning "pull the zork from the client at this path" to a boolean flag meaning "use the Zork in this client".@jab FYI
This change is