Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace with in-memory stream on recognize_whisper #647

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Replace with in-memory stream on recognize_whisper #647

merged 3 commits into from
Jan 9, 2023

Conversation

ftnext
Copy link
Collaborator

@ftnext ftnext commented Jan 9, 2023

Resolve #633

@ftnext ftnext self-assigned this Jan 9, 2023
@ftnext
Copy link
Collaborator Author

ftnext commented Jan 9, 2023

  • Run examples/microphone_recognition.py
  • Pass unit tests

👉 Merge it!

@ftnext ftnext merged commit c5bb4a3 into Uberi:master Jan 9, 2023
@ftnext ftnext deleted the i633-in-memory-stream branch January 9, 2023 09:34
This was referenced Jan 9, 2023
Closed
Closed
@NicolasBissig
Copy link

Thanks for the fix! When could this fix be released?

@nbrlt nbrlt mentioned this pull request Feb 19, 2023
Open
@EliasVincent EliasVincent mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ftnext ftnext

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In whisper implementation, tempfile is not required; In-memory stream can be used instead
2 participants
@ftnext @NicolasBissig