Update .listen_in_background to handle microphone disconnects #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify, this only happens on some of my Windows 10 systems. I'm really not sure why this is. You might have a bit of trouble reproducing this one. |
TomKranenburg
changed the title
ftnext
requested changes
Jan 12, 2023
There was a problem hiding this comment.
Thanks for this pull request.
This appears to address two issues at once.
This in turn makes merging more difficult, so it would be very helpful to me if this pull request could be split into two small pull requests.
Commit 2537ba1 is duplicated on #651 , so I think this pull request would be easier to merge if reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the opening of the audio source inside the thread loop. In a case where the audio source times out it will reconnect. This was causing problems on my own system when the mic is muted. The audio source would disconnect and not automatically reconnect.