Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prints that shouldn't be printed by default #651

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

kuzmoyev
Copy link
Contributor

closes #645

Copy link
Collaborator

@ftnext ftnext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request.

I think these print functions are not needed, too.
Deleting them is more suitable rather than commenting them out.

Commenting out is a great debugging technique.
But in a library implementation, it is not really suitable.

@kuzmoyev
Copy link
Contributor Author

Yes, I agree. I've just seen commented-out prints on other lines, so thought this is the approach in the project. I will delete them (and other commented-out prints)

Copy link
Collaborator

@ftnext ftnext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you so much for making SpeechRecogniton's code clean!

I will run the GitHub Actions and merge this after all passed.

@ftnext ftnext merged commit 010382b into Uberi:master Jan 12, 2023
@ftnext ftnext changed the title Comment out prints that shouldn't be printed by default Remove prints that shouldn't be printed by default Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize_google method not working as intended, solution provided here
2 participants