Allow nil indexing in world:target #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ukendio
requested changes
Sep 23, 2024
Ukendio
pushed a commit
that referenced
this pull request
Sep 29, 2024
* Removed error about needing `index` in `world:target` * The `index` parameter was made optional in #131 * Re-added `world.target` wrapper * Remove world.target and world.remove wrappers --------- Co-authored-by: EncodedVenom <32179912+EncodedVenom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description of your Changes.
This PR allows for users to use
world:target(entity, relationship, index)without specifying an index. If none is specified, this will default to0internally.For example,
Can now be written like:
Impact of your Changes
This will allow backwards compatibility with previous versions of jecs which did not have the index in
world:targetTests Performed
Added a test in the testing suite to track this change. This test passes CI.