Remove world:target debug error
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `index` parameter was made optional in #131
1Axen
changed the title
world:target debug errorworld:target debug error
EncodedVenom
requested changes
Sep 29, 2024
There was a problem hiding this comment.
For consistency with the World.remove definition below, I believe it would be best to change this to the following instead of outright deleting it:
World.target = function(world, entity, relation, index)
return world_target(world, entity, relation, index)
end
EncodedVenom
approved these changes
Sep 29, 2024
|
World.remove is most definitely a bug or a classic "I am going to work on this later but forgot to stash". I think we should probably remove the wrapper for both World.remove and World.target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This PR removes the debug error about
world:targetneeding anindexparameter.The parameter was made optional in #131.
Impact
This will fix compatibility with working code in non debug mode.