-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New 3 Joint Ragdoll Worm Environment #3798
Conversation
…g dynamic model now
@@ -3,7 +3,7 @@ | |||
--- !u!55 &1 | |||
PhysicsManager: | |||
m_ObjectHideFlags: 0 | |||
serializedVersion: 7 | |||
serializedVersion: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious this changed in the physics manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this change to the physics manager is. i didn't intentionally change any of the physics settings that i know of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good. Just have a few comments:
- We should only have one
WormDynamic.nn
file. I think we can delete the 28 million time-step one. - You'll want to add this environment (pic and description) to the
Learning-Environment-Examples.md
file in the docs. - Not for this PR, but once we have DynamicWalker, I am wondering how much of the code can be shared between the three locomotion agent types.
- Once this PR is merged, we will want this added to the daily training runs so we can benchmark it over time.
- Looks like you need to sign the CLA before we can accept the PR.
all changes made @awjuliani. i think it's ready for merge |
rotations for joints. | ||
* Visual Observations: None | ||
* Float Properties: None | ||
* Benchmark Mean Reward for `WormStaticTarget`: 150 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right, since for Crawler, the static reward is 5x the dynamic reward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i retrained to confirm benchmark. it scored 200 so i updated the doc. several reasons there is a huge difference.
- I increased the gravity to 1.5x so the worm is experiencing more gravity. The crawler can go much faster because it's essentially floating
- The worm has much weaker joints than the crawler. If the joints are strong it doesn't have natural oscillating motion. weaker joints mean it can't rely on launching itself foward like crawler does.
- all body segments on the worm are of mass 10. this is to give it a heavier look.
overall these changes were made to give the worm a less floaty look. I expected the benchmark to be lower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you updated worm dynamic to be higher than worm static. Is that right? I know the overall will be lower for both, but shouldn't static be better than dynamic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. error on my part. i updated it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐍
Is this going to get merged for the release? |
Proposed change(s)
New 3 Joint Ragdoll Worm Environment
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments
worm are cool i guess