fix: update responses mock for etag test #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was brought up in #275 that a test was failing. The reason appears to be because the response was passing
{}
back in a 304 which requests doesn't like. This behavior is consistent with RFC 7232 - 4.1 304 Not Modified i.e. a 304 should not have a body. Another way to confirm this is the root cause is to note the exceptionpoints out it read two bytes (
{}
) but expected nothing.Fixes #275
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: