Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update responses mock for etag test #277

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: update responses mock for etag test #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions tests/unit_tests/api/test_feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
from datetime import date

import pytest
import responses
from pytest import mark, param

Expand Down Expand Up @@ -89,15 +86,9 @@ def test_get_feature_toggle_failed_etag():
assert not etag


@pytest.mark.skipif(
date.today() < date(2023, 10, 1),
reason="This is currently breaking due to a dependency or the test setup. Skipping this allows us to run tests in CI without this popping up as an error all the time.",
)
@responses.activate
def test_get_feature_toggle_etag_present():
responses.add(
responses.GET, PROJECT_URL, json={}, status=304, headers={"etag": ETAG_VALUE}
)
responses.add(responses.GET, PROJECT_URL, status=304, headers={"etag": ETAG_VALUE})

(result, etag) = get_feature_toggles(
URL,
Expand Down
Loading