Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross compilation for armv7 is broken #34

Closed
binarybaron opened this issue Aug 27, 2024 · 0 comments · Fixed by #37
Closed

Cross compilation for armv7 is broken #34

binarybaron opened this issue Aug 27, 2024 · 0 comments · Fixed by #37
Labels
CI Related to Contineous Integration

Comments

@binarybaron
Copy link

binarybaron commented Aug 27, 2024 •
edited
Loading

E.g https://github.com/UnstoppableSwap/xmr-btc-swap/actions/runs/10582112253/job/29321031640

This due to the missing system dependencies which are required for Tauri to compile. This is a known issue cross-rs/cross#548
@binarybaron binarybaron mentioned this issue Aug 27, 2024
Merged
@binarybaron binarybaron added the CI Related to Contineous Integration label Aug 27, 2024
@Einliterflasche Einliterflasche mentioned this issue Aug 28, 2024
Merged
@Einliterflasche Einliterflasche linked a pull request Aug 28, 2024 that will close this issue
feat(swap): Tauri feature flag #37
Merged
binarybaron added a commit that referenced this issue Aug 28, 2024
@binarybaron
Merge pull request #37 from UnstoppableSwap/tauri-feature-flag
50539fe 
Introducing a feature flag in the swap crate that conditionally enables the tauri depencendy. This allows compiling the swap crate without the heavy tauri dependency. This also enables us to build arm binaries in the CI again.

This closes #32 and #34
binarybaron added a commit that referenced this issue Aug 28, 2024
@binarybaron
Merge pull request #37 from UnstoppableSwap/tauri-feature-flag
c7c7cf1 
Introducing a feature flag in the swap crate that conditionally enables the tauri depencendy. This allows compiling the swap crate without the heavy tauri dependency. This also enables us to build arm binaries in the CI again.

This closes #32 and #34
@github-staff github-staff deleted a comment from ViniciusSCG Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Related to Contineous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(swap): Tauri feature flag UnstoppableSwap/core
2 participants
@binarybaron and others