Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swap): Tauri feature flag #37

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat(swap): Tauri feature flag #37

merged 2 commits into from
Aug 28, 2024

Conversation

Einliterflasche
Copy link

@Einliterflasche Einliterflasche commented Aug 28, 2024

Introducing a feature flag in the swap crate that conditionally enables the tauri depencendy. This allows compiling the swap crate without the heavy tauri dependency. This also enables us to build arm binaries in the CI again.

This closes #32 and #34

@Einliterflasche Einliterflasche force-pushed the tauri-feature-flag branch 2 times, most recently from fb4cb9a to bcf98c0 Compare August 28, 2024 10:52
@Einliterflasche Einliterflasche linked an issue Aug 28, 2024 that may be closed by this pull request
@binarybaron binarybaron merged commit 50539fe into master Aug 28, 2024
28 of 29 checks passed
binarybaron added a commit that referenced this pull request Aug 28, 2024
Introducing a feature flag in the swap crate that conditionally enables the tauri depencendy. This allows compiling the swap crate without the heavy tauri dependency. This also enables us to build arm binaries in the CI again.

This closes #32 and #34
@binarybaron binarybaron changed the title feat(swap): tauri feature flag feat(swap): Tauri feature flag Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross compilation for armv7 is broken Hide Tauri integration behind feature flag
2 participants