Skip to content

Commit

Permalink
Switched order of concatonation for NEON UMAXP instruction to match H…
Browse files Browse the repository at this point in the history
…ardware.
  • Loading branch information
FinnWilkinson committed Nov 6, 2024
1 parent 32948cf commit 5945bae
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/include/simeng/arch/aarch64/helpers/neon.hh
Original file line number Diff line number Diff line change
Expand Up @@ -570,8 +570,8 @@ RegisterValue vecUMaxP(srcValContainer& sourceValues) {

// Concatenate the vectors
T temp[2 * I];
memcpy(temp, m, sizeof(T) * I);
memcpy(temp + (sizeof(T) * I), n, sizeof(T) * I);
memcpy(temp, n, sizeof(T) * I);
memcpy(temp + (sizeof(T) * I), m, sizeof(T) * I);
// Compare each adjacent pair of elements
T out[I];
for (int i = 0; i < I; i++) {
Expand Down
2 changes: 1 addition & 1 deletion test/regression/aarch64/instructions/neon.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2738,7 +2738,7 @@ TEST_P(InstNeon, umaxp) {
ldr q0, [x0]
ldr q1, [x0, #16]
umaxp v2.16b, v0.16b, v1.16b
umaxp v2.16b, v1.16b, v0.16b
)");
CHECK_NEON(2, uint8_t,
Expand Down

0 comments on commit 5945bae

Please sign in to comment.