Switch to IrodsPath, rename function #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 16, 2024 13:36
qubixes
requested changes
Aug 16, 2024
ibridges/tickets.py
Outdated
| elif check: | ||
| raise KeyError(f"Cannot delete ticket: ticket '{ticket}' does not exist (anymore).") | ||
|
|
||
| def update_tickets(self) -> list[TicketData]: | ||
| def list_tickets(self) -> list[TicketData]: |
There was a problem hiding this comment.
Are you sure you want to rename it? Now it looks kind of strange to simply call the method without using its contents.
There was a problem hiding this comment.
I found update_tickets confusing. We are not updating them but pull the information again from the iRODS server. So it is more a list or refresh.
There was a problem hiding this comment.
Okay, then let's go with refresh_tickets if you agree?
Co-authored-by: qubixes <44498096+qubixes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the listing function for tickets
Switch to IrodsPath