Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccessFeatureStatus on PathLink to indicate a broken access equipment. #235

Closed
wants to merge 1 commit into from

Conversation

trurlurl
Copy link
Contributor

AccessFeatureStatus on a PathLink to indicate a broken access equipment.

#194 asks for data to tell whether, e.g., an elevator is broken, but to nevertheless show the route so that the passenger knows that this route would exist but is currently not feasible.

EquipmentStatusEnumeration has been added from NeTEx to indicate the status of an access equipment. The following would indicate that the elevator is broken:

PathLink.AccessFeatureStatus: notAvailable (new)
PathLink.AccessFeatureType: elevator

The broken elevator makes the complete TransferLeg unfeasible - this should be flagged in the TransferLeg (e.g., TransferLeg.Feasibility : accessEquipmentOutOfService) or/and at the level of the Trip.
What solution would you prefer?

To also handle the case that the TranferLeg is not feasible due to a SituationFull (can that happen?), this could be indicated by:
TransferLeg.Feasibility: seeSituations

AccessFeatureStatus on a PathLink to indicate a broken access equipment.
@trurlurl trurlurl mentioned this pull request Aug 23, 2022
Copy link
Contributor

@ue71603 ue71603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be merged agains changes_for_1.1? Otherwise it is fine.

@ue71603 ue71603 changed the title Update OJP_Trips.xsd Add AccessFeatureStatus on PathLink to indicate a broken access equipment. Aug 25, 2022
@trurlurl
Copy link
Contributor Author

@skinkie Could you please review this? Also:
If this needs to be merged into changes_for_v1.1 rather than master - I don't seem to have the necessary permissions to change that.
Neither can I assign the item to reviewers. Do I just not find how to do it, or is it OK like that?

@ue71603
Copy link
Contributor

ue71603 commented Aug 26, 2022

Fixed in #238

@ue71603 ue71603 closed this Aug 26, 2022
@trurlurl trurlurl deleted the more_routing_information_194 branch November 29, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants