Add AccessibilityFeatures to PathLinkStructure, additional AccessFeatures, rename lift to elevator #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Aurige
reviewed
Aug 26, 2022
trurlurl
reviewed
Aug 27, 2022
|
André will update PR with the additional input. |
All enums, as discussed in the meeting.
Comments
trurlurl
reviewed
Oct 20, 2022
…nd-new-Accessibility-Features-attribute-(replaces-#236)
trurlurl
previously approved these changes
Oct 27, 2022
sgrossberndt
changed the title
sgrossberndt
previously requested changes
Nov 7, 2022
trurlurl
approved these changes
Nov 24, 2022
skinkie
approved these changes
Nov 24, 2022
sgrossberndt
approved these changes
Nov 24, 2022
sgrossberndt
deleted the
Additional-AccessFeature-Types-and-new-Accessibility-Features-attribute-(replaces-#236)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional AccessFeatureTypes and new AccessibilityFeatures attribute.
In the context of PR#234 and #235, I thought it would be good to add accessibility-related data like the following:
PathLink.AccessibilityFeatures: visualSigns, elevatorAccousticAnnouncements, elevatorTactileButtons, etc. This allows for returning accessiblity information attached to PathLinks.
I made AccessFeatureTypes more consistent and complete regarding the possible access equipments by adding singleStep, travelator, etc.
I also changed lift to elevator, to be consistent with NeTEx.