Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リファクタリング: create_accent_phrasesをSynthesisEngineに移動 #199

Merged
merged 8 commits into from
Nov 29, 2021

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Nov 23, 2021

内容

create_accent_phrases関数をrun.pyからSynthesisEngineに移動します。

関連 Issue

ref #119

その他

create_accent_phrases関数から使われているmora_to_text関数はsynthesis_engineに一時的に移動していますが、ほかのsynthesis_engine内の関数を含めて、別PRでモジュール化することを考えています。

@github-actions
Copy link

github-actions bot commented Nov 23, 2021

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 0 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 81 0 coverage-100%
voicevox_engine/full_context_label.py 145 7 coverage-95%
voicevox_engine/kana_parser.py 75 1 coverage-99%
voicevox_engine/model.py 70 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine.py 145 25 coverage-83%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 606 44 coverage-93%

@aoirint aoirint marked this pull request as draft November 23, 2021 10:10
@aoirint aoirint marked this pull request as ready for review November 23, 2021 10:14
@Hiroshiba
Copy link
Member

LGTM!!

モジュール化されるタイミングでテストを増やすのも良いかもと思いました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants