Skip to content

Commit

Permalink
Revert "WebPack builds for improved loading times (#3889)" (#4217)
Browse files Browse the repository at this point in the history
This reverts commit 1f80b2d.
  • Loading branch information
rickpr authored and jpoon committed Oct 26, 2019
1 parent 348857d commit e7f1cd7
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 1,630 deletions.
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ script:
echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve.";
exit 1;
fi
- gulp build
- gulp prepare-test
- npm run build
- npm test

before_deploy:
Expand Down
7 changes: 1 addition & 6 deletions .vscodeignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,4 @@ typings/**
**/*.map
.github_changelog_generator
.gitignore
*.yml
# Not needed, due to webpack
node_modules/
src/
tsconfig.json
webpack.config.js
*.yml
21 changes: 3 additions & 18 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ var gulp = require('gulp'),
ts = require('gulp-typescript'),
PluginError = require('plugin-error'),
minimist = require('minimist'),
path = require('path'),
webpack_stream = require('webpack-stream'),
webpack_config = require('./webpack.config.js');
path = require('path');

const exec = require('child_process').exec;
const spawn = require('child_process').spawn;
Expand Down Expand Up @@ -128,10 +126,6 @@ function updateVersion(done) {
});
}

function copyPackageJson() {
return gulp.src('./package.json').pipe(gulp.dest('out'));
}

gulp.task('tsc', function() {
var isError = false;

Expand All @@ -152,13 +146,6 @@ gulp.task('tsc', function() {
.pipe(gulp.dest('out'));
});

gulp.task('webpack', function() {
return gulp
.src('./extension.ts')
.pipe(webpack_stream(webpack_config))
.pipe(gulp.dest('out'));
});

gulp.task('tslint', function() {
const program = require('tslint').Linter.createProgram('./tsconfig.json');
return gulp
Expand Down Expand Up @@ -190,7 +177,7 @@ gulp.task('commit-hash', function(done) {
});

// test
gulp.task('run-test', function(done) {
gulp.task('test', function(done) {
// the flag --grep takes js regex as a string and filters by test and test suite names
var knownOptions = {
string: 'grep',
Expand Down Expand Up @@ -241,9 +228,7 @@ gulp.task('run-test', function(done) {
});
});

gulp.task('build', gulp.series('prettier', gulp.parallel('webpack', 'tslint'), 'commit-hash'));
gulp.task('prepare-test', gulp.parallel('tsc', copyPackageJson));
gulp.task('test', gulp.series('prepare-test', 'run-test'));
gulp.task('build', gulp.series('prettier', gulp.parallel('tsc', 'tslint'), 'commit-hash'));
gulp.task('changelog', gulp.series(validateArgs, createChangelog));
gulp.task(
'release',
Expand Down
Loading

0 comments on commit e7f1cd7

Please sign in to comment.