Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "WebPack builds for improved loading times (#3889)" #4217

Merged
merged 1 commit into from
Oct 26, 2019

Conversation

rickpr
Copy link
Contributor

@rickpr rickpr commented Oct 25, 2019

This reverts commit 1f80b2d.

What this PR does / why we need it: Neovim integration is broken due to Webpack. This reverts the Webpack commit to fix Neovim.

Which issue(s) this PR fixes #4126

Special notes for your reviewer: See comment below, I tested this locally to check that it fixes Neovim.

@rickpr
Copy link
Contributor Author

rickpr commented Oct 25, 2019

Tested this locally:
image

@jpoon jpoon merged commit e7f1cd7 into VSCodeVim:master Oct 26, 2019
J-Fields pushed a commit that referenced this pull request Oct 27, 2019
With the revert of the webpack build PR (#4217), we also need to revert the documentation change in CONTRIBUTING.md (#4128).
@rickpr rickpr deleted the fix/neovim branch November 18, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants