fix [close #194]: makes Remove and Add functions behave the same way #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the ABRoot behavior when adding and removing packages more consistent
Scenario:
pkg remove sudo - add to packages.remove
pkg remove sudo - do nothing
pkg add sudo - remove from packages.remove
pkg add sudo - add to packages.add
Works the same way the other way around.
Also prevents abroot from writing unnecessary entries to packages.unstaged. (duplicates and complements)
This is needed to prevent abroot from trying to install nonexistent packages.
Tested in a VM.