Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: CBA Extended Loadouts #1407

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Add: CBA Extended Loadouts #1407

merged 1 commit into from
Jan 22, 2023

Conversation

Vdauphin
Copy link
Owner

@Vdauphin Vdauphin commented Sep 13, 2022

When merged this pull request will:
- [ ] wait for IDI-Systems/acre2#1205 and remove :

if (["acre_api"] call ace_common_fnc_isModLoaded) then {
    _loadout = [_loadout] call acre_api_fnc_filterUnitLoadout;
};

Final test:

  • local
  • server

Screenshots

@Vdauphin Vdauphin added this to the 1.23 milestone Sep 13, 2022
if (["acre_api"] call ace_common_fnc_isModLoaded) then {
_loadout = [_loadout] call acre_api_fnc_filterUnitLoadout;
};

// Add earplugs to uniform if has them plugged in (temporary until Variables support)
if (_unit call ace_hearing_fnc_hasEarPlugsIn && {!((_loadout select 3) isEqualTo [])}) then {
((_loadout select 3) select 1) pushBack ["ACE_EarPlugs", 1];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've similar processing in my persistence system.
In current version, ACE will handle Ear Plugs only if CBA_fnc_getLoadout is called from a client with an interface.
You might need to keep this if the script is called from a dedicated server.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure they just forget about such case
It is better to fix ACE and ACRE

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@Vdauphin
Copy link
Owner Author

still waiting for acre

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Dec 4, 2022
@Vdauphin Vdauphin reopened this Dec 4, 2022
@Vdauphin Vdauphin merged commit 95d41e6 into master_daily Jan 22, 2023
@Vdauphin Vdauphin deleted the Add-use_cba_loadout branch January 22, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants