Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hearing - Fix CBA Extended Loadouts do not catch earplugs server side #9041

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

Vdauphin
Copy link
Contributor

When merged this pull request will:

  • Add CBA_loadoutSet event and CBA_loadoutGet event server and player side

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

CBA Extended Loadouts
@kymckay
Copy link
Member

kymckay commented Sep 18, 2022

Can you specify what this fixes instead of what it is?

@Vdauphin
Copy link
Contributor Author

CBA_fnc_getLoadout don't get the earplugs in when called server side
See comment here Vdauphin/HeartsAndMinds#1407 (comment)

@PabstMirror PabstMirror added this to the 3.15.2 milestone Sep 22, 2022
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Sep 22, 2022
@PabstMirror
Copy link
Contributor

need to change xeh as well

class Extended_PostInit_EventHandlers {
    class ADDON {
        clientinit = QUOTE(call COMPILE_SCRIPT(XEH_postInit));
    };
};

@PabstMirror PabstMirror merged commit 39cb42d into acemod:master Sep 23, 2022
@jonpas jonpas changed the title Hearing - Fix: CBA Extended Loadouts do not catch earplugs server side Hearing - Fix CBA Extended Loadouts do not catch earplugs server side Sep 23, 2022
@Vdauphin Vdauphin deleted the patch-5 branch September 23, 2022 18:42
BrettMayson pushed a commit to BrettMayson/ACE3 that referenced this pull request Oct 10, 2022
acemod#9041)

* Fix: Catch earplugs server side

CBA Extended Loadouts

* Remove events client side

* Add event to server and client
RusComBear pushed a commit to RusComBear/ACE3 that referenced this pull request Dec 29, 2023
acemod#9041)

* Fix: Catch earplugs server side

CBA Extended Loadouts

* Remove events client side

* Add event to server and client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants