don't delay loading node.exe due to imported data #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
CustomeExternalStringResource
extends V8'sExternalStringResource
, it imports the vftable which prevents delayed loading ofnode.exe
. Attempting to build the module withnode-gyp
results in the error LNK1194Further discussion:
nodejs/node#1266 - flag to disable delayed load
nodejs/node-gyp#599 - background
nodejs/node#751 - technical details
nodejs/node#1251 - technical details