Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share (Original YouTube link) #2487

Closed
jame25 opened this issue Dec 9, 2023 · 4 comments
Closed

Share (Original YouTube link) #2487

jame25 opened this issue Dec 9, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jame25
Copy link

jame25 commented Dec 9, 2023

I run a local instance of ViewTube (with a lan ip as the address) and I'd like to use the 'Share' feature to provide the original YouTube url for others.
@jame25 jame25 added the enhancement New feature or request label Dec 9, 2023
@AeliusSaionji
Copy link

AeliusSaionji commented Jan 12, 2024 •
edited
Loading

I have the same use case, would love to see this.

If it's not too much trouble, could we also include the youtube url somewhere on each thumbnail in search/subs/etc views?

For easy url sharing from all views, and also so it's easier to pass urls to mpv via browser extension.

Thanks.

chonsser added a commit to chonsser/viewtube that referenced this issue Jan 31, 2024
@chonsser
[Issue ViewTube#2487] Add YouTube share link option below the video
3d2e3f7 
* Add YouTube share button
* Handle non-HTTPS environment in copy operation
chonsser added a commit to chonsser/viewtube that referenced this issue Jan 31, 2024
@chonsser
[Issue ViewTube#2487] Remove unused import and require the videoId pr…
9ca716d 
…op. Fix formatting
@chonsser chonsser mentioned this issue Jan 31, 2024
Merged
chonsser added a commit to chonsser/viewtube that referenced this issue Feb 1, 2024
@chonsser
[Issue ViewTube#2487] Use messagesStore instead raw JS alert
aaf435a
moisout pushed a commit that referenced this issue Feb 2, 2024
@chonsser
✨ Add YouTube share link option below the video (#2610)
daab248 
* [Issue #2487] Add YouTube share link option below the video
* Add YouTube share button
* Handle non-HTTPS environment in copy operation

* [Issue #2487] Remove unused import and require the videoId prop. Fix formatting

* [Issue #2487] Use messagesStore instead raw JS alert
@ewoks
Copy link

ewoks commented Feb 2, 2024

great that there are movements on this 👏 will it land in next release?

@patricgruber
Copy link
Contributor

I think this issue can be closed, since as far as I can see the merged PR was part of release v0.15.2

@moisout moisout closed this as completed May 31, 2024
@jame25
Copy link
Author

jame25 commented Jun 14, 2024

I appreciate that this feature has now been implemented, however as I mention in OP - I run a local instance of ViewTube (without SSL). The 'Copy YouTube Link' button does not work in this scenerio.
viewtube

@iwannet iwannet mentioned this issue Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ewoks @AeliusSaionji @patricgruber @jame25 @moisout