-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/159 Upgrade VTS to .NET 8.0 #171
Conversation
…y EnumerableExtensions.ToDictionary()
Update .NET version
Update .NET version and action versions
@lmalenfant, what is the best way to check that I am running .NET 8 when I build this branch and try it? |
@hayakawa16 it will not let you build if you only have .NET 6. You can try it on Ubuntu without .NET 8 and I imagine it will give you an error. |
Thanks @lmalenfant! I will give it a try tomorrow. I plan to first try Windows, then install .NET 8 on Linux and try it there. |
I have installed .Net 8 already on my Windows machine. It builds without any issues. |
On Windows I pulled a clean clone, updated to the branch and ran unit tests. All works fine! So I ran from command line: When I do: hayakawa@ulam:~/vts_240912$ dotnet --list-runtimes It appears that my /src/Vts/obj/project.assets.json targets 6 like here: Did I do something wrong? |
… the archives to overwrite in case one exists
@hayakawa16 thank you for the detailed instructions, the publish in BuildTestReleaseMCCL.ps1 was still referencing .NET 6.0 so I removed the version and it should now work for future versions also. While I was fixing this issue, I noticed an issue with creating the archive files, the release folder is deleted when running BuildTestRelease but not BuildTestReleaseMCCL because it would delete the Scripting archives, I added -Force to the archive command to overwrite the existing file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mac didn't have .Net 8. Before updating to .Net 8, I got an error. After I installed .Net SDK 8.0.401 (x64) MacOS. everything works fine.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran unit tests in VS and ran BuildTestReleaseMCCL on Windows and Linux and all looks great! Thanks @lmalenfant for the hard work!
No description provided.