Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skyway] Raise the last individual observed event nonce for all validators once a nonce becomes observed #2159

Closed
byte-bandit opened this issue Sep 11, 2024 · 1 comment
Closed

[Skyway] Raise the last individual observed event nonce for all validators once a nonce becomes observed #2159

byte-bandit opened this issue Sep 11, 2024 · 1 comment
Assignees
@maharifu
Labels
enhancement New feature or request paloma

Comments

@byte-bandit
Copy link

byte-bandit commented Sep 11, 2024 •
edited by maharifu
Loading

Once an event becomes observed, we can safely raise the last observed nonce for all validators. This could prevent validators from being stuck trying to get old events after being offline for awhile. Also, since the event is already observed, having more validators attesting to it is just wasteful.
@maharifu maharifu mentioned this issue Sep 11, 2024
Merged
4 tasks
@maharifu maharifu added bug Something isn't working paloma enhancement New feature or request and removed bug Something isn't working labels Sep 11, 2024
taariq pushed a commit to palomachain/paloma that referenced this issue Sep 11, 2024
@maharifu
chore: update skyway validator nonces (#1288)
ef64f7a 
# Related Github tickets

- VolumeFi#2159

# Background

When a claim is set to observed, update all validator nonces if they
have a lower last observed nonce.

NOTE: This only takes effect when a claim is successfully attested to.
The validators currently stuck will remain on their current nonces until
a claim is processed. To get them unstuck, we need
VolumeFi#2160

# Testing completed

- [ ] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
@byte-bandit byte-bandit added this to the v2.2.1 milestone Sep 12, 2024
@taariq
Copy link
Member

taariq commented Sep 12, 2024

Shipped with palomachain#1288

@taariq taariq closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maharifu maharifu

Labels
enhancement New feature or request paloma
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@taariq @maharifu @byte-bandit