[Skyway] Paloma keeps a tap on outstanding pigeon evidences for events, pigeons can query those, and look directly at that block for the event in order to keep up #2160
Comments
4 tasks
taariq
pushed a commit
to palomachain/paloma
that referenced
this issue
Sep 11, 2024
# Related Github tickets - VolumeFi#2159 # Background When a claim is set to observed, update all validator nonces if they have a lower last observed nonce. NOTE: This only takes effect when a claim is successfully attested to. The validators currently stuck will remain on their current nonces until a claim is processed. To get them unstuck, we need VolumeFi#2160 # Testing completed - [ ] test coverage exists or has been added/updated - [x] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
This was referenced Sep 12, 2024
maharifu
added a commit
to palomachain/paloma
that referenced
this issue
Sep 12, 2024
# Related Github tickets - VolumeFi#2160 # Background Create an endpoint to return the blocks of missing skyway events for validators. This is used by pigeons to know which particular blocks they should query for events. # Testing completed - [x] test coverage exists or has been added/updated - [x] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
|
Shipped. |
4 tasks
maharifu
added a commit
to palomachain/paloma
that referenced
this issue
Sep 13, 2024
# Related Github tickets - VolumeFi#2160 # Background If we ever reset the latest skyway nonce ahead of any observed claim, we don't need nor want pigeons trying to attest to them. So, we can filter claims that are behind the latest attested claim. This should prevent pigeons from getting stuck trying to get old claims if their RPC fails, and we need to reset the nonce ahead of observed claims. # Testing completed - [x] test coverage exists or has been added/updated - [x] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
4 tasks
maharifu
added a commit
to palomachain/paloma
that referenced
this issue
Sep 13, 2024
# Related Github tickets - VolumeFi#2160 # Background The way it was before, we would need a claim to be observed so validators would be updated. By doing it in the endblocker, we validators are always up-to-date. This should prevent a situation where the last claim is 19, the last observed nonce is 18, but validators are stuck on nonce 17. They would receive a list of block events with the block of nonce 19 (latest unobserved) but would be unable to claim it, since skyway would expect them to submit a claim for nonce 18 instead. # Testing completed - [ ] test coverage exists or has been added/updated - [x] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Instead of having pigeons go back a huge amount of blocks to get skyway events, we have pigeons query paloma for outstanding claims. Pigeons will then query these blocks directly for events and move on from there.
This should be used only when pigeons fall behind on events, so pigeons can keep their own events ordered.
The text was updated successfully, but these errors were encountered: