-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library/test_search segfault on master #1671
Comments
adding print statements, I identified that the segfault happens "between" these two lines, just after the get_task_data:
It seems to be the case also when executing from python |
With the recent updates to master, we now get some extra details:
|
I coulnd't have a chance to spend some time on this again, will anyone from the "official" team be able to have a look? |
We've been making some headway on issues, so they may be dealt with
soonish.
…-Jon
On Mon, Jan 28, 2019 at 1:55 PM Jp ***@***.***> wrote:
I coulnd't have a chance to spend some time on this again, will anyone
from the "official" team be able to have a look?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1671 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE25uBcCgiKkC1HauS1Fx5XYGp1rM4Cks5vH0edgaJpZM4YNHKl>
.
|
I've been looking at the other hook task issue and it seems like this may be the same issue. The higher-level issue is that we explicitly disable "hook" - which seems to have been around for a while. That is fixed by removing the check in search.cc's setup(). The next-level issue is that this uses the old API for multi-line example, which fails the multi-line test. Switching to multi_ex as input fixes that. The underlying issue is that setting the right function-pointers in SearchTask's init (in libsearch.h) does not seem to actually set them in the task-object that hook-task is looking into. Still trying to debug why that is going on. |
I believe I have a fix for this - just need to do a bit more validation under Linux. After that will check whether there is more work (I expect there will be, to propagate the API changes through the Python library). Here's the branch in my fork: https://github.com/lokitoth/vowpal_wabbit/tree/dev/Fix-SearchHookTaskCppLibrary |
wonderful, thanks a lot for looking into it! I will try to recompile my
C++ code later this week on your branch. I'm working exclusively on linux
so this will hopefully test that side of the house a bit more.
thanks again!
…On Tue, Feb 26, 2019 at 4:32 PM Jacob Alber ***@***.***> wrote:
I believe I have a fix for this - just need to do a bit more validation
under Linux. After that will check whether there is more work (I expect
there will be, to propagate the API changes through the Python library).
Here's the branch in my fork:
lokitoth/vowpal_wabbit:dev/Fix-SearchHookTaskCppLibrary
cc @jprobichaud <https://github.com/jprobichaud>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1671 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI0166l_TrDuLHSBY5co1NNWlYBDHBomks5vRaf8gaJpZM4YNHKl>
.
|
Perhaps caused by the same issue as issue "Hook interface" #1413, building vw and then doing
Also results in a core dump
This is on ArchLinux, 64bit, with GCC 8.2.1 and Boost 1.68
The text was updated successfully, but these errors were encountered: