Fix L2S HookTask in c-library and Python bindings #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
force-pushed
the
dev/Fix-SearchHookTask
branch
2 times, most recently
from
9499277
to
798e626
Compare
jackgerrits
approved these changes
Apr 3, 2019
* Also update for API-level changes (search now takes in multi_ex as input rather than example*)
The change to free_ptr<search> for the local variable broke the code to register the search pointer, as it started putting the pointer to the free_ptr, rather than to the search object.
lokitoth
force-pushed
the
dev/Fix-SearchHookTask
branch
from
798e626
to
9f64843
Compare
|
Went over this in person with @hal3. |
|
Merged, thanks :-) |
jackgerrits
pushed a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
May 15, 2019
* Remove code to disable hook task * Make test_search build under Windows * Also update for API-level changes (search now takes in multi_ex as input rather than example*) * Fix search::setup to put right data into all.searchstr The change to free_ptr<search> for the local variable broke the code to register the search pointer, as it started putting the pointer to the free_ptr, rather than to the search object. * Fix libsearch.h to use the multi_ex interface correctly * Fix test_search.cc to do string concatenation correctly * Enable test_search to build under Windows * Fix Python L2S HookTask binding to use multi_ex properly * Set the options_i pointer in HookTask::task_data properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago the "hook" L2S task was broken, and subsequently explicitly disabled. This change fixes it.
The underlying issues were around setting up the pointers to hook into correctly and update to the new multi-line example API, as the code changed due to various refactorings.
Fixes #1413, though there are still issues with LDF.
Fixes #1671