-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options_i
command line parsing refactor
#1706
Merged
JohnLangford
merged 69 commits into
VowpalWabbit:master
from
jackgerrits:jagerrit/migrate_options
Jan 16, 2019
Merged
Changes from 50 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
dbf5dee
Initial framework commit of options refactor
jackgerrits 45627b0
Rename options -> arguments, option -> parameter
jackgerrits 2e4d6fb
equality unit test
jackgerrits aa35d8a
Working on tests
jackgerrits f20f73d
Add kept implementation
jackgerrits 8b3dacc
revert line ending change
jackgerrits b12c3a9
Update cmake and fix build
jackgerrits a53364f
Update arg to hold value, expose arg list and merging
jackgerrits f317655
Rename arguments to options
jackgerrits 196af06
rename files arguments -> options
jackgerrits c548106
Add config namespace
jackgerrits f2d8da8
Change back to non-duplicates and use references
jackgerrits 9d443d1
Migration progress:
jackgerrits 056081e
Migrate model header load
jackgerrits 19f6087
Migrate parse_feature_tweaks
jackgerrits 5e9951e
migrate parse_example_tweaks
jackgerrits ddb0222
migrate parse_output_model and parse_output_preds
jackgerrits bd42a7e
Change to using reference instead of pointer for options object
jackgerrits 212f57e
Migrate marginal reduction
jackgerrits 201f34a
Change all signatures to include options_i and vw
jackgerrits de0408f
migrate gd
jackgerrits 3be311e
Migrate kernel svm and fix keep arg in marginal
jackgerrits 020325c
migrate ftrl reduction
jackgerrits c4ebae5
migrate svrg reduction
jackgerrits 7982425
migrate sender
jackgerrits 969ddd7
migrate gd_mf
jackgerrits 3c88834
work in progress
jackgerrits 1225797
Update loss_function to be able to dynamically identify type
jackgerrits 34f967a
work in progress
jackgerrits 8defa86
Finish migrating reductions, and search tasks
jackgerrits e0dc05d
fix compile issues in vw_core
jackgerrits 86126ff
working through test fixes
jackgerrits ed66172
fix bugs
jackgerrits 6e8a7e6
Fix bug, update test model file
jackgerrits c2204c4
Fix tests, update cppcli wrapper, update c# unit tests, fix c# versio…
jackgerrits 7a1d2be
Fix help printout, unregistered options check
jackgerrits 8a82af8
merge conflicts
jackgerrits 0b9fb19
Fix options leaked object
jackgerrits 02045b1
remove width of print for older boost version
jackgerrits b52586e
update usage of options in python and remove program_options referenc…
jackgerrits 25628da
add move constructor, fix onethread unregistered issue and fix false …
jackgerrits bb2fa9e
try not using move constructors
jackgerrits 7f006c1
move to a unique ptr to deal with gcc4.9
jackgerrits cd07648
fix save resume
jackgerrits bf8b3f1
trigger ci
jackgerrits 3f7cf1a
implement positional parameter for data and revert test changes
jackgerrits d3bf228
properly handle invalid args for Java
jackgerrits ba475f7
fix writing if incorrect cb_type to model
jackgerrits 78c7f2a
fix --opt=val style parsing from model file args
jackgerrits 861fd81
change handling of defaults for cb_type, change insert behavior for e…
jackgerrits 13de7d8
Merge branch 'master' into jagerrit/migrate_options
jackgerrits 31a001c
Fix merge conflict, kvm loss function check is fixed in this PR
jackgerrits cb0b7c0
revert unwanted changes
jackgerrits 1aaafe7
revert Resource.rc removal
jackgerrits 533f101
revert adding include
jackgerrits a5528b7
fix kernel_svn -> kernel_svm
jackgerrits 0ef8449
Use const& for strings and larger objects in options
jackgerrits 8a0679c
Fix lgtm alert about copy assignment operator
jackgerrits 9e10531
Merge branch 'master' into jagerrit/migrate_options
jackgerrits 0bea867
add back <algorithm> for min/max
jackgerrits 4dec969
using namespace VW::config;
jackgerrits 89b5959
fix java dependencies, update cpprestsdk build
jackgerrits 9b5215c
Revert "fix java dependencies, update cpprestsdk build"
jackgerrits 6d9cae3
return reference from, rename make function
jackgerrits f3b022b
remove options.cc
jackgerrits dce63d8
use given reference for setup_base
jackgerrits fa7f6d3
remove fields from all
jackgerrits 9337bed
Merge branch 'master' into jagerrit/migrate_options
jackgerrits 2e32eb7
merge commit
jackgerrits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered removing the extra ->?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which
->
are you referring to?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->get_typed_option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is actually a situation where we need a pointer rather than a reference here. If a command line is supplied we must construct the options_i object for the user, and so we must delete when the vw object is deleted. We could could cast our reference to a pointer in this case but I think we should avoid that. Most usages of options_i in the system is through references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite following this. Deleting of members seems routine?