Small fix: uninitialized skip argument resulted in segfaults #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnLangford
added a commit
that referenced
this pull request
Jun 18, 2012
Small fix: uninitialized skip argument resulted in segfaults
|
Thanks, added. -John On 06/17/2012 10:46 PM, Stephen Merity wrote:
|
lokitoth
pushed a commit
to lokitoth/vowpal_wabbit
that referenced
this pull request
Dec 20, 2019
* fix memory leak in Rank * merge fix into existing loop * clean up examples first before pushing back to pool
jackgerrits
referenced
this pull request
in jackgerrits/vowpal_wabbit
Aug 4, 2020
Fix compiliation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skip argument that modifies ngram was not initialized in global_data.cc and resulted in segfaults.
Trivial fix is to set a default of zero in global_data.
Starting program: /home/smerity/Coding/Reference/vowpal_wabbit/vowpalwabbit/vw wsj_caps_00 --loss_function logistic -c --passes 20 -f caps.model --l2 0.0001 --bfgs --conjugate_gradient --ngram 3 [Thread debugging using libthread_db enabled] ... You have chosen to generate 3-grams ... [New Thread 0x7ffff46b3700 (LWP 12214)] [Switching to Thread 0x7ffff46b3700 (LWP 12214)] Breakpoint 1, addgrams (all=..., ngram=1, skip_gram=140737353958624, atomics=..., audits=..., initial_length=21, gram_mask=..., skips=0) at parser.cc:515 515 if (ngram == 0 && gram_mask.last() < initial_length) (gdb)