fix memory leak in Rank (VowpalWabbit#31)

* fix memory leak in Rank * merge fix into existing loop * clean up examples first before pushing back to pool
lokitoth · Jan 11, 2019 · 4299daf · 4299daf
1 parent 6bbaba2
commit 4299daf
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/rlclientlib/vw_model/safe_vw.cc b/rlclientlib/vw_model/safe_vw.cc
@@ -138,9 +138,11 @@ namespace reinforcement_learning {
       scores[i] = predictions[i].score;
     }
 
-    // push examples back into pool for re-use
-    for (auto&& ex : examples)
+    // clean up examples and push examples back into pool for re-use
+    for (auto&& ex : examples) {
+      ex->pred.a_s.delete_v();
       _example_pool.emplace_back(ex);
+    }
 
     // cleanup
     examples.delete_v();