allow user configuration #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed order of dictionaries in a call to extend that lets user options passed as a dictionary to the Bundle command override default parameters obtained by parsing the repository url.
Added a section on passing options to the Bundle command.
edited the vundle#installer#install function to lookup (and use) the configuration specified by the users Bundle commands.
| let b = bb | ||
| break | ||
| endif | ||
| endfor |
There was a problem hiding this comment.
I did the same thing with a simple code in my pull request #200
let n = substitute(a:name,"['".'"]\+','','g')
let b = filter(copy(g:bundles), 'v:val.name_spec == n')[0]
|
I've looked into this. |
|
rtp is supported by now - what's current status of this PR? |
|
I think this was already addressed in #406. If I'm right this one can be closed. |
|
Indeed, this is already implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, now that I understand how the options framework is setup...
I switched the order of the s:parse_name and s:parse_options calls in the init_bundle function so that user options will override defaults set from the bundle name. The three options that can now be set are 'rtp', 'name' and 'uri'. the 'name' option is handy if you want to bundle to be cloned to a different directory than the repositories name. the 'uri' option is probably most useful for allowing you to clone ssh:// repos, you can specify a bundle name like 'gmarik/vundle' and pass { 'uri' : 'ssh://git@github.com/gmarik/vundle' } to allow you to clone your push accessible repo.
I hope this isn't an already supported feature that I just couldn't figure out how to use.