Make bundle options visible to installer #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle configuration options that are inferred from the bundle specs overwrite user provided ones. This used to prevent users from changing the name of directory where the cloned bundle should go, for instance. Keep the user provided options with a preference over inferred ones.
This was referenced Mar 20, 2014
|
@gmarik @starcraftman Please take a look. @gmarik I think you wanted additional options to be shown in the installer. We can do that separately without blocking this. |
|
@jdevera It does work as I expect. Hope it could be accepted. |
|
@jdevera Looks good, just curious why runtimepath is in |'s? |
|
From
So basically, so you can jump to the existing help topic on runtimepath. |
|
@jdevera Alright, works for me. No need to delay this any longer than. Merging. @darkshell In future, please don't close bugs until fixed. |
starcraftman
added a commit
that referenced
this pull request
Mar 20, 2014
Allows Bundle plugin folder renaming.
|
cool, i like this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle configuration options that are inferred from the bundle specs
overwrite user provided ones. This used to prevent users from changing the
name of directory where the cloned bundle should go, for instance.
Keep the user provided options with a preference over inferred ones.