-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implements JVL command for zeroing position encoder, calls on winch startup #22
Conversation
There's a typo in the service definition, "registry". If this is the correct way to do it, then it seems like a good change. |
ec178fa
to
2d0db0d
Compare
Good catch, fixed |
@rgov can you think of any side effects of using this? i.e. position drift from being reset too many times? (Seems unlikely since position is calibrated by CTD depth). Thinking about adding a config option to disable this command as a backup. |
I have no experience outside this project. I don't think we need to add an option; either it works and we continue using it or it doesn't and we deploy a hot fix to revert back. It would give me more confidence to know that this is indeed exactly how MacTalk resets the encoder position. We can do that by using MacTalk with WireShark, for example. |
2d0db0d
to
68d1ea7
Compare
Haven't merged yet because I still hope to do this; haven't had the proper setup yet. |
68d1ea7
to
a21266a
Compare
a21266a
to
ed3dd1b
Compare
I am not 100% sure about zeroing at startup since in theory the zero point would best be the median depth? If the total encoder range is more than enough to cover the depth range that's probably fine though. Merge when you're happy with it! |
I'm going to take a closer look at MacTalk values in the lab next week - but we've been using this in the field long enough that I'm going to merge for now so that I can finally stop rebasing on top of it for every deployment. Will open a new issue if I find anything wrong with the procedure in lab. |
No description provided.