Add trigger_data_matching field to Flexible Event explainer #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
force-pushed
the
modulus-range
branch
2 times, most recently
from
7a75b9d
to
71b656c
Compare
apasel422
force-pushed
the
modulus-range
branch
from
8dc933b
to
066ed0c
Compare
apasel422
force-pushed
the
modulus-range
branch
from
066ed0c
to
a61a1e5
Compare
johnivdel
approved these changes
Oct 4, 2023
|
slgtm |
|
RS LGTM |
csharrison
approved these changes
Oct 9, 2023
vikassahu29
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to retain backwards compatibility with the existing modulus behavior while allowing sources to opt in to exact matching. Other matching modes, such as
clamp_min,clamp_max, andclamp, could be added in the future.Fixes #765