Specify trigger-data matching #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
commented
Oct 9, 2023
johnivdel
reviewed
Oct 10, 2023
Because the rest of the Full Flex proposal hasn't been specified yet, there is no way for a source to use non-default trigger data. As written, the spec inherently ensures that the source's allowed trigger data is in the range |
johnivdel
approved these changes
Oct 10, 2023
akashnadan
approved these changes
Oct 12, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 23, 2023
WICG/attribution-reporting-api#1064 This is gated at parsing time by a new feature that is disabled by default. Note that we do not need a DB migration because the default behavior, modulus, is retained for existing sources that lack the new field. We expose the field in the Attribution Internals UI and the experimental DevTools protocol event for source registrations. We use a wrapper type in both C++ and Mojo because that encapsulation will be necessary when the fields from WICG/attribution-reporting-api#1074 are added in a followup change. OBSOLETE_HISTOGRAM[Conversions.CreateReportStatus8]=Replaced by Conversions.CreateReportStatus9 OBSOLETE_HISTOGRAM[Conversions.SentVerboseDebugReportType3]=Replaced by Conversions.SentVerboseDebugReportType4 OBSOLETE_HISTOGRAM[Conversions.SourceRegistrationError5]=Replaced by Conversions.SourceRegistrationError6 Bug: 1493766 Change-Id: Icf5624f42f29f06f6e7bf56162e51fafc71b66ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4936470 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1213766}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1044
Preview | Diff