Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need timestamp from the initiation of the navigation, not the navigation event #12

Closed
esprehn opened this issue Feb 3, 2021 · 2 comments · Fixed by #27
Closed

Need timestamp from the initiation of the navigation, not the navigation event #12

esprehn opened this issue Feb 3, 2021 · 2 comments · Fixed by #27

Comments

@esprehn
Copy link

esprehn commented Feb 3, 2021

For reporting user interaction metrics we need the start of the user action, not the start of the navigation.

For example if a user clicks the Next button 10 times rapidly (per the photo gallery example), the navigate event for the 10th won't fire until all the previous 9 navigations and respondWith()'s have completed. That makes the start time stamp very low by comparison to the user perceived time to get to that destination, which is "Click 10th time" until "URL Change".

I'm not sure the use case for currently defined "navigation event start time" given the arbitrarily long start delay before it's recorded.

domenic added a commit that referenced this issue Feb 5, 2021
Closes #8 by renaming. Closes #12 by changing the semantics to when the navigation is initiated.

This might be refined further as we figure out navigation queuing.
domenic added a commit that referenced this issue Feb 5, 2021
Closes #8 by renaming. Closes #12 by changing the semantics to when the navigation is initiated.

This might be refined further as we figure out navigation queuing.
@tbondwilkinson
Copy link
Contributor

I suspect that we should start counting from the time the appHistory API is called.

Domenic is this already done? Mark as closed?

@domenic
Copy link
Collaborator

domenic commented Feb 11, 2021

This is being worked in #27, which is not yet merged due to outstanding questions.

domenic added a commit that referenced this issue Feb 11, 2021
Closes #8 by renaming to something shorter, although not to the proposed name since navigationStart is apparently deprecated.

Closes #12 by changing the semantics to when the navigation is initiated to be more useful.

Points to #33 for further work on this area.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants