Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTMLTableRowElement's insertCell doesn't need CEReactions #595

Closed
rniwa opened this issue Oct 26, 2016 · 1 comment
Closed

HTMLTableRowElement's insertCell doesn't need CEReactions #595

rniwa opened this issue Oct 26, 2016 · 1 comment
Assignees
@annevk
Labels
custom-elements

Comments

@rniwa
Copy link
Collaborator

rniwa commented Oct 26, 2016

HTMLTableRowElement's insertCell doesn't need CEReactions because it never creates or connects a custom element.
@domenic
Copy link
Collaborator

domenic commented Oct 26, 2016

Nice find, thanks. Somehow I missed this in whatwg/html#1398.

annevk added a commit to whatwg/html that referenced this issue Oct 26, 2016
@annevk
Correct [CEReactions] usage on HTMLOptionsCollection and HTMLTableRow…
6393a6f 
…Element

In particular when setting HTMLOptionsCollection’s length, option
elements can be removed that might have descendant custom elements for
which disconnectedCallback should trigger.

When using HTMLTableRowElement’s insertCell(), a custom element can
never be inserted or affected.

Fixes WICG/webcomponents#596 and fixes
WICG/webcomponents#595.
@annevk annevk mentioned this issue Oct 26, 2016
Merged
@annevk annevk self-assigned this Oct 26, 2016
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@annevk
Correct some [CEReactions] usage
c6501a5 
When setting HTMLOptionsCollection's length, option elements can be
removed that might have descendant custom elements, for which
disconnectedCallback should trigger, so we need to add [CEReactions].
Fixes WICG/webcomponents#596.

When using HTMLTableRowElement's insertCell(), a custom element can
never be inserted or affected, so we can remove [CEReactions]. Fixes
WICG/webcomponents#595.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annevk annevk

Labels
custom-elements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rniwa @domenic @annevk