Correct [CEReactions] usage on HTMLOptionsCollection and HTMLTableRowElement #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Element In particular when setting HTMLOptionsCollection’s length, option elements can be removed that might have descendant custom elements for which disconnectedCallback should trigger. When using HTMLTableRowElement’s insertCell(), a custom element can never be inserted or affected. Fixes WICG/webcomponents#596 and fixes WICG/webcomponents#595.
domenic
added
the
topic: custom elements
domenic
added
the
needs tests
|
I have written tests locally but haven't landed them into WebKit or wrote a PR for web-platform-tests since I'm out sick today. Will try to finish that up tomorrow. |
zcorpan
previously requested changes
Oct 28, 2016
| @@ -8543,7 +8543,7 @@ partial interface <dfn id="document" data-dfn-lt="">Document</dfn> { | |||
| // <span>dynamic markup insertion</span> | |||
| [<span>CEReactions</span>] <span>Document</span> <span data-x="dom-document-open">open</span>(optional DOMString type = "text/html", optional DOMString replace = ""); | |||
| <span>WindowProxy</span> <span data-x="dom-document-open">open</span>(USVString url, DOMString name, DOMString features); | |||
| [<span>CEReactions</span>] void <span data-x="dom-document-close">close</span>(); | |||
| void <span data-x="dom-document-close">close</span>(); | |||
There was a problem hiding this comment.
This reverts commit 07c5bfa.
|
Let's merge this since we know the WebKit tests are coming. |
domenic
removed
the
needs tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular when setting HTMLOptionsCollection’s length, option
elements can be removed that might have descendant custom elements for
which disconnectedCallback should trigger.
When using HTMLTableRowElement’s insertCell(), a custom element can
never be inserted or affected.
Fixes WICG/webcomponents#596 and fixes
WICG/webcomponents#595.