Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with ServiceWorker #221

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Integrate with ServiceWorker #221

merged 5 commits into from
Sep 28, 2022

Conversation

nondebug
Copy link
Collaborator

@nondebug nondebug commented Jun 17, 2022 •
edited by pr-preview bot
Loading

Closes #22

Preview | Diff

reillyeon
reillyeon requested changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should include notes that,

  • While the specification defines how the API is exposed in shared workers, there is no implementation for this.
  • Implementations may choose when to expose this API to service workers and that current implementation experience is limited to service workers in browser extension contexts.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
reillyeon
reillyeon approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

index.bs Outdated Show resolved Hide resolved
@reillyeon reillyeon merged commit be1693e into WICG:main Sep 28, 2022
github-actions bot added a commit that referenced this pull request Sep 28, 2022
@nondebug @github-actions
Integrate with ServiceWorker (#221)
122af3c 
SHA: be1693e
Reason: push, by @reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Sep 28, 2022
@nondebug @github-actions
Integrate with ServiceWorker (#221)
a451f5d 
SHA: be1693e
Reason: push, by @reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nondebug nondebug deleted the service-worker branch September 28, 2022 17:37
@skyclouds2001 skyclouds2001 mentioned this pull request Oct 4, 2024
Closed
reillyeon added a commit that referenced this pull request Oct 4, 2024
@reillyeon
Be consistent about worker interface exposure
43478a5 
In #221 we added specification text for how this API could be exposed to
service workers but did not update the [Exposed] attribute in most of
the WebIDL blocks. This updates the remaining blocks.

Fixed #249.
@reillyeon reillyeon mentioned this pull request Oct 4, 2024
Merged
reillyeon added a commit that referenced this pull request Oct 4, 2024
@reillyeon
Be consistent about worker interface exposure (#250)
f756c9f 
In #221 we added specification text for how this API could be exposed to
service workers but did not update the [Exposed] attribute in most of
the WebIDL blocks. This updates the remaining blocks.

Fixed #249.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reillyeon reillyeon reillyeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define WebUSB from Service Workers
2 participants
@nondebug @reillyeon