Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be consistent about worker interface exposure #250

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

reillyeon
Copy link
Collaborator

@reillyeon reillyeon commented Oct 4, 2024

In #221 we added specification text for how this API could be exposed to service workers but did not update the [Exposed] attribute in most of the WebIDL blocks. This updates the remaining blocks.

Fixed #249.


Preview | Diff

In #221 we added specification text for how this API could be exposed to
service workers but did not update the [Exposed] attribute in most of
the WebIDL blocks. This updates the remaining blocks.

Fixed #249.
@reillyeon reillyeon requested a review from nondebug October 4, 2024 18:43
Copy link
Collaborator

@nondebug nondebug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reillyeon reillyeon merged commit f756c9f into main Oct 4, 2024
2 checks passed
@reillyeon reillyeon deleted the consistent_worker branch October 4, 2024 20:41
github-actions bot added a commit that referenced this pull request Oct 4, 2024
SHA: f756c9f
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 4, 2024
SHA: f756c9f
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent scope expose for interfaces
2 participants