#201 required chainid

Example/ExampleApp/Wallet/WalletViewController.swift

@@ -158,7 +158,7 @@ extension WalletViewController: ProposalViewControllerDelegate {
         let proposal = currentProposal!
         currentProposal = nil
         let accounts = Set(proposal.namespaces.first?.chains.compactMap { Account($0.absoluteString + ":\(account)") } ?? [])
-        client.approve(proposalId: proposal.id, accounts: accounts, namespaces: proposal.namespaces)
+        try! client.approve(proposalId: proposal.id, accounts: accounts, namespaces: proposal.namespaces)
     }
 
     func didRejectSession() {

Sources/WalletConnect/Engine/PairingEngine.swift

@@ -70,6 +70,12 @@ final class PairingEngine {
     }
     func propose(pairingTopic: String, namespaces: Set<Namespace>, relay: RelayProtocolOptions, completion: @escaping ((Error?) -> ())) {
         logger.debug("Propose Session on topic: \(pairingTopic)")
+        do {
+            try Namespace.validate(namespaces)
+        } catch {
+            completion(error)
+            return
+        }
         let publicKey = try! kms.createX25519KeyPair()
         let proposer = Participant(
             publicKey: publicKey.hexRepresentation,

Sources/WalletConnect/Engine/SessionEngine.swift

@@ -107,7 +107,7 @@ final class SessionEngine {
         }
     }
 
-    func emit(topic: String, event: SessionType.EventParams.Event, chainId: Blockchain?, completion: ((Error?)->())?) {
+    func emit(topic: String, event: SessionType.EventParams.Event, chainId: Blockchain, completion: ((Error?)->())?) {
         guard let session = sessionStore.getSession(forTopic: topic), session.acknowledged else {
             logger.debug("Could not find session for topic \(topic)")
             return
@@ -145,7 +145,8 @@ final class SessionEngine {
         }.store(in: &publishers)
     }
 
-    func settle(topic: String, proposal: SessionProposal, accounts: Set<Account>, namespaces: Set<Namespace>) {
+    func settle(topic: String, proposal: SessionProposal, accounts: Set<Account>, namespaces: Set<Namespace>) throws {
+        try Namespace.validate(namespaces)
         let agreementKeys = try! kms.getAgreementSecret(for: topic)!
 
         let selfParticipant = Participant(publicKey: agreementKeys.publicKey.hexRepresentation, metadata: metadata)
@@ -218,20 +219,14 @@ final class SessionEngine {
             networkingInteractor.respondError(for: payload, reason: .noContextWithTopic(context: .session, topic: topic))
             return
         }
-        if let chain = request.chainId {
-            guard session.hasNamespace(for: chain) else {
-                networkingInteractor.respondError(for: payload, reason: .unauthorizedTargetChain(chain.absoluteString))
-                return
-            }
-            guard session.hasNamespace(for: chain, method: request.method) else {
-                networkingInteractor.respondError(for: payload, reason: .unauthorizedMethod(request.method))
-                return
-            }
-        } else {
-            guard session.hasNamespace(for: nil, method: request.method) else {
-                networkingInteractor.respondError(for: payload, reason: .unauthorizedMethod(request.method))
-                return
-            }
+        let chain = request.chainId
+        guard session.hasNamespace(for: chain) else {
+            networkingInteractor.respondError(for: payload, reason: .unauthorizedTargetChain(chain.absoluteString))
+            return
+        }
+        guard session.hasNamespace(for: chain, method: request.method) else {
+            networkingInteractor.respondError(for: payload, reason: .unauthorizedMethod(request.method))
+            return
         }
         onSessionRequest?(request)
     }

Sources/WalletConnect/Engine/SessionStateMachines/SessionStateMachineValidating.swift

@@ -7,17 +7,6 @@ protocol SessionStateMachineValidating {
 
 extension SessionStateMachineValidating {
     func validateNamespaces(_ namespaces: Set<Namespace>) throws {
-        for namespace in namespaces {
-            for method in namespace.methods {
-                if method.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty {
-                    throw WalletConnectError.invalidMethod
-                }
-            }
-            for event in namespace.events {
-                if event.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty {
-                    throw WalletConnectError.invalidEvent
-                }
-            }
-        }
+        try Namespace.validate(namespaces)
     }
 }

Sources/WalletConnect/Namespace.swift

@@ -10,3 +10,24 @@ public struct Namespace: Codable, Equatable, Hashable {
         self.events = events
     }
 }
+
+internal extension Namespace {
+
+    static func validate(_ namespaces: Set<Namespace>) throws {
+        for namespace in namespaces {
+            guard !namespace.chains.isEmpty else {
+                throw WalletConnectError.namespaceHasEmptyChains
+            }
+            for method in namespace.methods {
+                if method.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty {
+                    throw WalletConnectError.invalidMethod
+                }
+            }
+            for event in namespace.events {
+                if event.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty {
+                    throw WalletConnectError.invalidEvent
+                }
+            }
+        }
+    }
+}

Sources/WalletConnect/NetworkInteractor/NetworkInteractor.swift

@@ -264,6 +264,6 @@ class NetworkInteractor: NetworkInteracting {
 
     func getChainId(_ request: WCRequest) -> String? {
         guard case let .sessionRequest(payload) = request.params else {return nil}
-        return payload.chainId?.absoluteString
+        return payload.chainId.absoluteString
     }
 }

Sources/WalletConnect/Request.swift

@@ -6,17 +6,17 @@ public struct Request: Codable, Equatable {
     public let topic: String
     public let method: String
     public let params: AnyCodable
-    public let chainId: Blockchain?
+    public let chainId: Blockchain
 
-    internal init(id: Int64, topic: String, method: String, params: AnyCodable, chainId: Blockchain?) {
+    internal init(id: Int64, topic: String, method: String, params: AnyCodable, chainId: Blockchain) {
         self.id = id
         self.topic = topic
         self.method = method
         self.params = params
         self.chainId = chainId
     }
 
-    public init(topic: String, method: String, params: AnyCodable, chainId: Blockchain?) {
+    public init(topic: String, method: String, params: AnyCodable, chainId: Blockchain) {
         self.id = Self.generateId()
         self.topic = topic
         self.method = method

Sources/WalletConnect/Types/Session/SessionType.swift

@@ -60,7 +60,7 @@ internal enum SessionType {
 
     struct RequestParams: Codable, Equatable {
         let request: Request
-        let chainId: Blockchain?
+        let chainId: Blockchain
 
         struct Request: Codable, Equatable {
             let method: String
@@ -70,7 +70,7 @@ internal enum SessionType {
 
     struct EventParams: Codable, Equatable {
         let event: Event
-        let chainId: Blockchain?
+        let chainId: Blockchain
 
         struct Event: Codable, Equatable {
             let name: String

Sources/WalletConnect/Types/Session/WCSession.swift

@@ -69,6 +69,7 @@ struct WCSession: ExpirableSequence {
         namespaces.contains{$0.chains.contains(chain)}
     }
 
+    // TODO: Remove optional for chain param, it's required now / protocol change
     func hasNamespace(for chain: Blockchain?, method: String) -> Bool {
         if let chain = chain {
             let namespacesIncludingChain = namespaces.filter{$0.chains.contains(chain)}

Sources/WalletConnect/WalletConnectClient.swift

@@ -170,10 +170,11 @@ public final class WalletConnectClient {
     public func approve(
         proposalId: String,
         accounts: Set<Account>,
-        namespaces: Set<Namespace>) {
+        namespaces: Set<Namespace>
+    ) throws {
             //TODO - accounts should be validated for matching namespaces
         guard let (sessionTopic, proposal) = pairingEngine.respondSessionPropose(proposerPubKey: proposalId) else {return}
-            sessionEngine.settle(topic: sessionTopic, proposal: proposal, accounts: accounts, namespaces: namespaces)
+        try sessionEngine.settle(topic: sessionTopic, proposal: proposal, accounts: accounts, namespaces: namespaces)
     }
 
     /// For the responder to reject a session proposal.
@@ -259,7 +260,7 @@ public final class WalletConnectClient {
     ///   - topic: Session topic
     ///   - params: Event Parameters
     ///   - completion: calls a handler upon completion
-    public func emit(topic: String, event: Session.Event, chainId: Blockchain?, completion: ((Error?)->())?) {
+    public func emit(topic: String, event: Session.Event, chainId: Blockchain, completion: ((Error?)->())?) {
         sessionEngine.emit(topic: topic, event: event.internalRepresentation(), chainId: chainId, completion: completion)
     }
 

Sources/WalletConnect/WalletConnectError.swift

@@ -6,6 +6,7 @@ enum WalletConnectError: Error {
     case noSessionMatchingTopic(String)
     case sessionNotAcknowledged(String)
     case pairingNotSettled(String)
+    case namespaceHasEmptyChains
     case invalidMethod
     case invalidEvent
     case invalidUpdateExpiryValue
@@ -39,6 +40,8 @@ extension WalletConnectError {
             return "Pairing is not settled on topic \(topic)."
         case .invalidUpdateExpiryValue:
             return "Update expiry time is out of expected range"
+        case .namespaceHasEmptyChains:
+            return "Namespace has an empty list of chain IDs."
         case .invalidMethod:
             return "Methods set is invalid."
         case .invalidEvent:

Tests/IntegrationTests/ClientTest.swift

@@ -55,7 +55,7 @@ final class ClientTests: XCTestCase {
         let uri = try! await proposer.client.connect(namespaces: [Namespace.stub()])!
         try! responder.client.pair(uri: uri)
         responder.onSessionProposal = { [unowned self] proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [account], namespaces: [])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [account], namespaces: [])
         }
         responder.onSessionSettled = { sessionSettled in
             // FIXME: Commented assertion
@@ -81,7 +81,7 @@ final class ClientTests: XCTestCase {
         try! responder.client.pair(uri: uri)
 
         responder.onSessionProposal = { [unowned self] proposal in
-            responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
+            try? responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
         }
         responder.onSessionSettled = { sessionSettled in
             responderSettlesSessionExpectation.fulfill()
@@ -119,7 +119,7 @@ final class ClientTests: XCTestCase {
         let uri = try! await proposer.client.connect(namespaces: [Namespace.stub()])!
         _ = try! responder.client.pair(uri: uri)
         responder.onSessionProposal = {[unowned self]  proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
         }
         proposer.onSessionSettled = {[unowned self]  settledSession in
             Task {
@@ -142,7 +142,7 @@ final class ClientTests: XCTestCase {
 
         _ = try! responder.client.pair(uri: uri)
         responder.onSessionProposal = {[unowned self]  proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: proposal.namespaces)
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: proposal.namespaces)
         }
         proposer.onSessionSettled = {[unowned self]  settledSession in
             let requestParams = Request(id: 0, topic: settledSession.topic, method: method, params: AnyCodable(params), chainId: Blockchain("eip155:1")!)
@@ -180,7 +180,7 @@ final class ClientTests: XCTestCase {
         let uri = try! await proposer.client.connect(namespaces: [Namespace.stub(methods: [method])])!
         _ = try! responder.client.pair(uri: uri)
         responder.onSessionProposal = {[unowned self]  proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: proposal.namespaces)
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: proposal.namespaces)
         }
         proposer.onSessionSettled = {[unowned self]  settledSession in
             let requestParams = Request(id: 0, topic: settledSession.topic, method: method, params: AnyCodable(params), chainId: Blockchain("eip155:1")!)
@@ -211,7 +211,7 @@ final class ClientTests: XCTestCase {
 
         try! responder.client.pair(uri: uri)
         responder.onSessionProposal = { [unowned self] proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
         }
         proposer.onSessionSettled = { [unowned self] sessionSettled in
             self.proposer.client.ping(topic: sessionSettled.topic) { response in
@@ -230,7 +230,7 @@ final class ClientTests: XCTestCase {
         let uri = try! await proposer.client.connect(namespaces: [Namespace.stub()])!
         try! responder.client.pair(uri: uri)
         responder.onSessionProposal = { [unowned self] proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [account], namespaces: [])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [account], namespaces: [])
         }
         responder.onSessionSettled = { [unowned self] sessionSettled in
             try? responder.client.updateAccounts(topic: sessionSettled.topic, accounts: updateAccounts)
@@ -253,7 +253,7 @@ final class ClientTests: XCTestCase {
         let namespacesToUpdateWith: Set<Namespace> = [Namespace(chains: [Blockchain("eip155:1")!, Blockchain("eip155:137")!], methods: ["xyz"], events: ["abc"])]
         try! responder.client.pair(uri: uri)
         responder.onSessionProposal = { [unowned self] proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
         }
         responder.onSessionSettled = { [unowned self] session in
             try? responder.client.updateNamespaces(topic: session.topic, namespaces: namespacesToUpdateWith)
@@ -275,7 +275,7 @@ final class ClientTests: XCTestCase {
         let uri = try! await proposer.client.connect(namespaces: [Namespace.stub()])!
         try! responder.client.pair(uri: uri)
         responder.onSessionProposal = { [unowned self] proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
         }
         responder.onSessionSettled = { [unowned self] session in
             Thread.sleep(forTimeInterval: 1) //sleep because new expiry must be greater than current
@@ -292,16 +292,16 @@ final class ClientTests: XCTestCase {
 
     func testSessionEventSucceeds() async {
         let proposerReceivesEventExpectation = expectation(description: "Proposer receives event")
-        let namespace = Namespace(chains: [], methods: [], events: ["type1"])
+        let namespace = Namespace(chains: [Blockchain("eip155:1")!], methods: [], events: ["type1"]) // TODO: Fix namespace with empty chain array / protocol change
         let uri = try! await proposer.client.connect(namespaces: [namespace])!
 
         try! responder.client.pair(uri: uri)
         let event = Session.Event(name: "type1", data: AnyCodable("event_data"))
         responder.onSessionProposal = { [unowned self] proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [namespace])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [namespace])
         }
         responder.onSessionSettled = { [unowned self] session in
-            responder.client.emit(topic: session.topic, event: event, chainId: nil, completion: nil)
+            responder.client.emit(topic: session.topic, event: event, chainId: Blockchain("eip155:1")!, completion: nil)
         }
         proposer.onEventReceived = { event, _ in
             XCTAssertEqual(event, event)
@@ -318,10 +318,10 @@ final class ClientTests: XCTestCase {
         try! responder.client.pair(uri: uri)
         let event = Session.Event(name: "type2", data: AnyCodable("event_data"))
         responder.onSessionProposal = { [unowned self] proposal in
-            self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
+            try? self.responder.client.approve(proposalId: proposal.id, accounts: [], namespaces: [])
         }
         proposer.onSessionSettled = { [unowned self] session in
-            proposer.client.emit(topic: session.topic, event: event, chainId: nil) { error in
+            proposer.client.emit(topic: session.topic, event: event, chainId: Blockchain("eip155:1")!) { error in
                 XCTAssertNotNil(error)
             }
         }