[Sign/Web3Wallet] Add pending proposals #744
Conversation
| guard let proposal = try? record.request.params?.get(SessionType.ProposeParams.self) | ||
| else { return nil } | ||
|
|
||
| return Session.Proposal( |
There was a problem hiding this comment.
you can use SessionProposal's publicRepresentation(pairingTopic: String) -> Session.Proposal here
| let requestSubscriptionPayloads = pendingHistory | ||
| .compactMap { record -> RequestSubscriptionPayload<SessionType.ProposeParams>? in | ||
| guard let proposalParams = mapProposeParams(record) else { | ||
| return nil | ||
| } | ||
| return RequestSubscriptionPayload(id: record.id, topic: record.topic, request: proposalParams, publishedAt: Date()) | ||
| } | ||
|
|
||
| requestSubscriptionPayloads.forEach { | ||
| let proposal = $0.request | ||
| proposalPayloadsStore.set($0, forKey: proposal.proposer.publicKey) | ||
| } |
There was a problem hiding this comment.
you do it to set values to proposalPayloadsStore on app launch?
There was a problem hiding this comment.
Only when you request for pending proposals
| guard let proposalParams = mapProposeParams(record) else { | ||
| return nil | ||
| } | ||
| return RequestSubscriptionPayload(id: record.id, topic: record.topic, request: proposalParams, publishedAt: Date()) |
There was a problem hiding this comment.
I don't like we are recreating RequestSubscriptionPayload type here.
could we change type stored by proposalPayloadsStore?
There was a problem hiding this comment.
Me neither. Your proposal sounds legit 👍
alexander-lsvk
changed the title
|
|
||
| requestSubscriptionPayloads.forEach { | ||
| let proposal = $0.request | ||
| proposalPayloadsStore.set($0, forKey: proposal.proposer.publicKey) |
There was a problem hiding this comment.
why we cannot remove proposalPayloadsStore and depend on rpc history only?
If big array of expired proposals the only reason I think it's fine. We can fix it when implement expiration logic for proposals
ghost
mentioned this pull request
|
@alexander-lsvk any blockers on this PR? |
Due Dilligence