This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Update JS test harnesses to match changes to interpreter harness #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script/js.ml changed and started emitting different JS harness code. This commit updates sync_index.js and async_index.js to match.
rossberg
approved these changes
Mar 30, 2020
|
Thanks for the review! Is there something blocking this from landing? CI looks like an unrelated failure. |
|
Sorry, nothing blocking. But I'm not always aware who has commit rights. ;) Landing it. |
Not a problem, thanks! |
rossberg
pushed a commit
that referenced
this pull request
May 14, 2020
* Fix expected trap messages. The spec interpreter says "element segment dropped", rather than "elements segment dropped". * Fix "zero len, but dst offset out of bounds" test. Fix this test to test what it's comment says it's testing. * Add more tests for zero-length operations. * Update the Overview text to reflect the zero-length at-the-end semantics.
rossberg
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script/js.ml changed and started emitting different JS harness code.
This commit updates sync_index.js and async_index.js to match.