Remove subtyping #87

rossberg · 2020-04-29T10:45:41Z

Per the vote on #69, this PR removes subtyping from the proposal. List of changes:

Syntax:
- remove nullref type
- rename anyref type to externref
- extend ref.null and ref.is_null instructions with new immediate of the form func or extern (this will later have to generalise to a constype per the typed references proposal)
Typing rules:
- ref.null, ref.is_null: determine reference type based on new immediate
- select, call_indirect, table.copy, table.init: drop subtyping
- br_table: revert to rule requiring same label types
- elem segment: drop subtyping
- global import: drop subtyping (link time)
Remove subtyping rules and bottom type.
Revert typing algorithm (interpreter and spec appendix).
JS API:
- remove "nullref"
- rename "anyref" to "externref"
Scripts:
- rename ref result to ref.extern
- rename ref.host value to ref.extern
- drop subtyping from invocation type check
JS translation:
- extend harness with separate eq functions for each ref type
Adjust tests:
- apply syntax changes
- remove tests for subtyping
- change tests exercising subtyping in other ways

binji

lgtm

binji · 2020-05-06T00:34:28Z

document/js-api/index.bs

@@ -902,9 +898,7 @@ which can be simultaneously referenced by multiple {{Instance}} objects. Each
    1. If |valuetype| equals [=𝗂𝟨𝟦=], return [=𝗂𝟨𝟦.𝖼𝗈𝗇𝗌𝗍=] 0.
    1. If |valuetype| equals [=𝖿𝟥𝟤=], return [=𝖿𝟥𝟤.𝖼𝗈𝗇𝗌𝗍=] 0.
    1. If |valuetype| equals [=𝖿𝟨𝟦=], return [=𝖿𝟨𝟦.𝖼𝗈𝗇𝗌𝗍=] 0.
-    1. If |valuetype| equals [=nullref=], return [=ref.null=].
    1. If |valuetype| equals [=anyref=], return [=ToWebAssemblyValue=](undefined, |valuetype|).


binji · 2020-05-06T00:35:08Z

interpreter/README.md

 offset: offset=<nat>
 align: align=(1|2|4|8|...)
 cvtop: trunc | extend | wrap | ...

 num_type: i32 | i64 | f32 | f64
-ref_type: anyref | funcref | nullref
+ref_kind: any | func


s/any/extern/

binji · 2020-05-06T00:53:19Z

proposals/reference-types/Overview.md

@@ -47,8 +46,8 @@ Notes:

 Typing extensions:

-* Introduce `anyref`, `funcref`, and `nullref` as a new class of *reference types*.
-  - `reftype ::= anyref | funcref | nullref`
+* Introduce `funref` and `externref` as a new class of *reference types*.


binji · 2020-05-06T00:59:53Z

test/core/linking.wast

  (global (import "Mref_ex" "g-const-func") funcref)
-  (global (import "Mref_ex" "g-const-func") anyref)
-  (global (import "Mref_ex" "g-const-any") anyref)
+  (global (import "Mref_ex" "g-const-any") externref)


might want to rename these to "g-const-extern" too

binji · 2020-05-06T01:01:20Z

test/core/ref_func.wast

@@ -9,8 +9,8 @@
    (i32.add (local.get $x) (i32.const 1))
  )

-  (global anyref (ref.func $f))
-  (global anyref (ref.func $g))
+  (global externref (ref.null extern))


can be removed now?

Update the implementation given WebAssembly/reference-types#87 which removed subtyping and renamed "anyref" to "externref"

Update the implementation given WebAssembly/reference-types#87 which has a number of changes to the reference types implementation: * Subtyping is removed * `nullref` as a type was removed * `anyref` was renamed to `externref` * `ref.null` and `ref.is_null` take immediate type arguments as to what kind of `null` they're producing. The spec testsuite repo has not yet updated with this change yet, so the tests are temporarily vendored here in the `tests/wast` directory.

* Update implementation of reference types Update the implementation given WebAssembly/reference-types#87 which has a number of changes to the reference types implementation: * Subtyping is removed * `nullref` as a type was removed * `anyref` was renamed to `externref` * `ref.null` and `ref.is_null` take immediate type arguments as to what kind of `null` they're producing. The spec testsuite repo has not yet updated with this change yet, so the tests are temporarily vendored here in the `tests/wast` directory. * Update TypedSelect validation

Change the test generators to use `ref.func` and remove `passive`. At some point we'll want to remove the generators, but for let's try to maintain them.

…ly/reference-types#87

WebAssembly/reference-types#87

anyref future semantics were changed to only represent opaque host values, and thus renamed to externref. [Chromium](https://bugs.chromium.org/p/v8/issues/detail?id=7748#c360) was just updated to today (not yet released). I couldn't find a Mozilla bugzilla ticket mentioning externref so I don't immediately know if they've updated yet. WebAssembly/reference-types#87

This updates reference types proposal up-to-date, per WebAssembly/reference-types#87. Only maybe half of tests have been updated, so CI will not pass. I was in the process of updating them fully, but I noticed WebAssembly#3084, so I'm not sure if I continue to do this anymore. I asked him if he wanted to do it himself to prevent this situation but apparently my questions weren't answered and I didn't know that he was working on this at the same time. I'm uploading this anyway in case this is necessary for discussions.

This updates reference types proposal up-to-date, per WebAssembly/reference-types#87. Only maybe half of tests have been updated, so CI will not pass. I was in the process of updating them fully, but then I noticed WebAssembly#3084, so I'm not sure if I should continue to do this anymore. I asked him if he wanted to do it himself to prevent this situation but apparently my questions weren't answered and I didn't know that he was working on this at the same time. I'm uploading this anyway in case this is necessary for discussions.

https://bugs.webkit.org/show_bug.cgi?id=218885 Patch by Dmitry Bezhetskov <dbezhetskov@igalia.com> on 2020-11-18 Reviewed by Yusuke Suzuki. Make funcref is not a subtype of externref. The spec: https://webassembly.github.io/reference-types/core/ The PR for removing subtype from the spec: WebAssembly/reference-types#87. JSTests: * wasm/references/func_ref.js: (assert.eq.instance.exports.fix.fun): (assert.eq.instance.exports.fix): * wasm/references/validation.js: Source/JavaScriptCore: * wasm/WasmFormat.h: (JSC::Wasm::isSubtype): * wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser<Context>::parseExpression): * wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::link): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@270015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=218885 Patch by Dmitry Bezhetskov <dbezhetskov@igalia.com> on 2020-11-18 Reviewed by Yusuke Suzuki. Make funcref is not a subtype of externref. The spec: https://webassembly.github.io/reference-types/core/ The PR for removing subtype from the spec: WebAssembly/reference-types#87. JSTests: * wasm/references/func_ref.js: (assert.eq.instance.exports.fix.fun): (assert.eq.instance.exports.fix): * wasm/references/validation.js: Source/JavaScriptCore: * wasm/WasmFormat.h: (JSC::Wasm::isSubtype): * wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser<Context>::parseExpression): * wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::link): Canonical link: https://commits.webkit.org/231756@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

rossberg added 5 commits April 29, 2020 11:20

Remove nullref

5e231e9

Remove funcref subtyping

009626d

Completely remove subtyping

c594220

Tweak ref.is_null

dd91463

Rename anyref to externref

3bafde2

rossberg requested a review from binji April 29, 2020 10:45

dtig mentioned this pull request Apr 30, 2020

Please add notes of April 14th meeting WebAssembly/meetings#551

Closed

eqrion mentioned this pull request May 5, 2020

Remove funcref as a subtype of anyref bytecodealliance/wat#85

Merged

binji approved these changes May 6, 2020

View reviewed changes

binji mentioned this pull request May 6, 2020

Reference types changes to remove subtyping WebAssembly/wabt#1407

Merged

Comments

a5960f4

rossberg merged commit 551e876 into master May 7, 2020

rossberg deleted the nosub branch May 7, 2020 07:38

RossTate mentioned this pull request May 7, 2020

call_indirect versus abstraction WebAssembly/design#1343

Open

alexcrichton added a commit to alexcrichton/wasmparser.rs that referenced this pull request May 12, 2020

Update implementation of reference types

5055396

Update the implementation given WebAssembly/reference-types#87 which removed subtyping and renamed "anyref" to "externref"

alexcrichton mentioned this pull request May 12, 2020

Update implementation of reference types bytecodealliance/wasmparser#213

Merged

rossberg pushed a commit that referenced this pull request May 14, 2020

Fix merge conflicts introduced w/ PRs #84 and #86 (#87)

e2e3383

Change the test generators to use `ref.func` and remove `passive`. At some point we'll want to remove the generators, but for let's try to maintain them.

Pauan mentioned this pull request May 16, 2020

web-sys: Add Blob.stream() method rustwasm/wasm-bindgen#2140

Merged

Horcrux7 added a commit to i-net-software/JWebAssembly that referenced this pull request May 30, 2020

anyref --> externref, add kind to ref.null and ref.is_null, WebAssemb…

cfbadfa

…ly/reference-types#87

jayphelps mentioned this pull request Jun 9, 2020

exnref name vs. externref WebAssembly/exception-handling#114

Closed

jayphelps added a commit to jayphelps/binaryen that referenced this pull request Jun 9, 2020

Rename anyref to externref to match proposal change

b49bfc9

WebAssembly/reference-types#87

jayphelps mentioned this pull request Jun 9, 2020

Rename anyref to externref to match proposal change WebAssembly/binaryen#2900

Merged

jayphelps added a commit to jayphelps/binaryen that referenced this pull request Jun 9, 2020

Rename anyref to externref to match proposal change

2fd7464

WebAssembly/reference-types#87

jayphelps added a commit to jayphelps/binaryen that referenced this pull request Jun 9, 2020

Rename anyref to externref to match proposal change

5bb1c9c

WebAssembly/reference-types#87

jayphelps mentioned this pull request Jun 9, 2020

Rename anyref to externref to match proposal change AssemblyScript/assemblyscript#1319

Merged

1 task

taralx mentioned this pull request Jun 12, 2020

Remove type annotations on ref.as_non_null and br_on_null WebAssembly/function-references#31

Merged

dcodeIO mentioned this pull request Jun 19, 2020

Reference types for phase 4? #61

Closed

jayphelps mentioned this pull request Aug 22, 2020

Add new compound Signature, Struct and Array types WebAssembly/binaryen#3012

Merged

aheejin mentioned this pull request Aug 31, 2020

Implement changes in reference types proposal WebAssembly/binaryen#3086

Closed

jakobkummerow mentioned this pull request Sep 2, 2020

Relationship between all the heap types WebAssembly/gc#131

Closed

rossberg mentioned this pull request Sep 22, 2020

[spec/interpreter/test] Reintroduce bottom type #116

Merged

rossberg mentioned this pull request Oct 14, 2020

"Bottom type" in spec? WebAssembly/spec#1257

Closed

wingo mentioned this pull request Oct 29, 2020

externref/funcref distinction fundamental for toolchain? WebAssembly/tool-conventions#150

Closed

rossberg mentioned this pull request Nov 17, 2020

Casting null WebAssembly/gc#152

Closed

dbezhetskov mentioned this pull request Dec 7, 2020

Missing design rationals for type annotated select #125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove subtyping #87

Remove subtyping #87

rossberg commented Apr 29, 2020 •

edited

Loading

binji left a comment

binji May 6, 2020

rossberg May 7, 2020

binji May 6, 2020

rossberg May 7, 2020

binji May 6, 2020

rossberg May 7, 2020

binji May 6, 2020

rossberg May 7, 2020

binji May 6, 2020

rossberg May 7, 2020

Remove subtyping #87

Remove subtyping #87

Conversation

rossberg commented Apr 29, 2020 • edited Loading

binji left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rossberg commented Apr 29, 2020 •

edited

Loading