This repository has been archived by the owner on May 20, 2020. It is now read-only.
Remove funcref as a subtype of anyref #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes. This will help parsing of type-immediate ref.null and ref.is_null. Eventually we may be able to combine TableElemType with RefType as well.
alexcrichton
approved these changes
May 5, 2020
| #[allow(missing_docs)] | ||
| #[derive(Debug, PartialEq, Eq, Hash, Copy, Clone)] | ||
| pub enum RefType<'a> { | ||
| Func, |
There was a problem hiding this comment.
Mind adding a few comments to the variants here? The first two I think are reference-types proposal types, the next is exception handling, and everything else is the gc proposal, right?
There was a problem hiding this comment.
Yes, that's the case. I've added some comments explaining the types.
crates/wast/src/ast/types.rs
Outdated
| parser.parse::<kw::r#extern>()?; | ||
| Ok(RefType::Extern) | ||
| } else if l.peek::<kw::any>() { | ||
| parser.parse::<kw::any>()?; |
There was a problem hiding this comment.
Are there any old tests using (ref any) after everything is renamed?
There was a problem hiding this comment.
No, there shouldn't really be any. Might be some in wabt, but they'll update at some point. I've removed the alias for this form.
eqrion
force-pushed
the
subtype
branch
2 times, most recently
from
d7bff68
to
c5ef489
Compare
alexcrichton
approved these changes
May 7, 2020
The type uses the formal reference-types production, so it's `ref.null any` not `ref.null anyref`. The elem segment parser also had to be updated to check the type of ref.null used is compatible with the element segment type. This is tricky with subtypes, so for now it just does strict equality.
`anyref` is going to be a tricky thing to rename, if even possible. For now an alias seems to be reasonable.
This is unfortunate, but I don't see a way around it if we want to not be blocked on wabt. At the least, we do have extensive test coverage in spidermonkey for these testsuites that will continue.
|
Yes, let's merge this and get a new version when you get a chance! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of the syntax changes in WebAssembly/reference-types/pull/87. I have a corresponding patch in SpiderMonkey that tests this out with the semantics changes as well.
It may be good to hold off on merging this until the upstream PR is closer to merging, to track any changes. I'm posting this now to just get ready for when that is.