This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
Update implementation of reference types #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the implementation given WebAssembly/reference-types#87 which has a number of changes to the reference types implementation: * Subtyping is removed * `nullref` as a type was removed * `anyref` was renamed to `externref` * `ref.null` and `ref.is_null` take immediate type arguments as to what kind of `null` they're producing. The spec testsuite repo has not yet updated with this change yet, so the tests are temporarily vendored here in the `tests/wast` directory.
src/operators_validator.rs
Outdated
| self.func_state.change_frame_after_select(ty)?; | ||
| } | ||
| Operator::TypedSelect { ty } => { | ||
| self.check_operands_3(Type::I32, ty, ty)?; | ||
| self.check_operands_3(ty, ty, Type::I32)?; |
There was a problem hiding this comment.
just noticed how wrong Operator::TypedSelect is for dead code, we need to match the check_select logic here (later?)
nvm, it's fine since we don't have to infer type here
There was a problem hiding this comment.
Ah I went ahead and updated this so they use the same code path for consistency anyway.
yurydelendik
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the implementation given WebAssembly/reference-types#87 which has
a number of changes to the reference types implementation:
nullrefas a type was removedanyrefwas renamed toexternrefref.nullandref.is_nulltake immediate type arguments as to whatkind of
nullthey're producing.The spec testsuite repo has not yet updated with this change yet, so the
tests are temporarily vendored here in the
tests/wastdirectory.